Hi Leif and Ard, Please help to review this and merge it if you have no comments on this patch.
Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Wednesday, May 19, 2021 11:30 PM > To: Schaefer, Daniel <daniel.schae...@hpe.com>; devel@edk2.groups.io > Cc: Leif Lindholm <l...@nuviainc.com>; Ard Biesheuvel > <ard.biesheu...@arm.com>; Anup Patel <anup.pa...@wdc.com> > Subject: Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp > and strncpy to libfdt_env.h > > Reviewed-by: Abner Chang <abner.ch...@hpe.com> > > > -----Original Message----- > > From: Schaefer, Daniel > > Sent: Wednesday, May 19, 2021 10:58 PM > > To: devel@edk2.groups.io > > Cc: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>; > Leif > > Lindholm <l...@nuviainc.com>; Ard Biesheuvel > <ard.biesheu...@arm.com>; > > Anup Patel <anup.pa...@wdc.com> > > Subject: [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to > > libfdt_env.h > > > > OpenSBI has started using those in v0.9. See: > > https://github.com/riscv/opensbi/blob/v0.9/lib/utils/fdt/fdt_domain.c > > > > Cc: Abner Chang <abner.ch...@hpe.com> > > Cc: Leif Lindholm <l...@nuviainc.com> > > Cc: Ard Biesheuvel <ard.biesheu...@arm.com> > > Cc: Daniel Schaefer <daniel.schae...@hpe.com> > > Cc: Anup Patel <anup.pa...@wdc.com> > > Signed-off-by: Daniel Schaefer <daniel.schae...@hpe.com> > > --- > > EmbeddedPkg/Include/libfdt_env.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/EmbeddedPkg/Include/libfdt_env.h > > b/EmbeddedPkg/Include/libfdt_env.h > > index 7feff52bc0fb..c35ac739703c 100644 > > --- a/EmbeddedPkg/Include/libfdt_env.h > > +++ b/EmbeddedPkg/Include/libfdt_env.h > > @@ -76,8 +76,16 @@ static inline size_t strnlen (const char* str, size_t > strsz ) { > > return AsciiStrnLenS (str, strsz); > > > > } > > > > > > > > +static inline size_t strcmp (const char* str1, const char* str2) { > > > > + return AsciiStrCmp (str1, str2); > > > > +} > > > > + > > > > static inline size_t strncmp (const char* str1, const char* str2, size_t > > strsz ) > { > > > > return AsciiStrnCmp (str1, str2, strsz); > > > > } > > > > > > > > +static inline size_t strncpy (char* dest, const char* source, size_t > dest_max) { > > > > + return AsciiStrCpyS (dest, dest_max, source); > > > > +} > > > > + > > > > #endif /* _LIBFDT_ENV_H */ > > > > -- > > 2.30.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77791): https://edk2.groups.io/g/devel/message/77791 Mute This Topic: https://groups.io/mt/82938220/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
