> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, July 29, 2021 4:23 PM
> To: [email protected]; [email protected]; Wang, Jian J
> <[email protected]>
> Cc: [email protected]; Yao, Jiewen <[email protected]>;
> Laszlo Ersek <[email protected]>
> Subject: RE: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/FvReportPei:
> remove redundant sizeof
> 
> > -----Original Message-----
> > From: [email protected] <[email protected]> On Behalf Of
> > wenyi,xie via groups.io
> > Sent: Thursday, July 29, 2021 3:45 PM
> > To: [email protected]; Wang, Jian J <[email protected]>; Wu,
> > Hao A <[email protected]>
> > Cc: [email protected]; [email protected]; Yao, Jiewen
> > <[email protected]>; Laszlo Ersek <[email protected]>
> > Subject: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/FvReportPei:
> > remove redundant sizeof
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3333
> >
> > In function InstallPreHashFvPpi, when calculating the size of struct
> > HASH_INFO,sizeof is used twice. This bug does not lead to buffer
> > overflow, "sizeof (HASH_INFO)" is 4, whereas "sizeof (sizeof
> > (HASH_INFO))" is 4 or 8.
> 
> 
> Thanks.
> Reviewed-by: Hao A Wu <[email protected]>
> 
> I will wait a couple days before merging to see if any additional comment
> from other reviewers.


Really sorry, please ignore the previous mail sent (giving the Reviewed-by tag).
It was sent by accident. Withdraw my R-b tag for this patch.

Best Regards,
Hao Wu


> 
> Best Regards,
> Hao Wu
> 
> 
> >
> > Cc: Jiewen Yao <[email protected]>
> > Cc: Jian J Wang <[email protected]>
> > Cc: Laszlo Ersek <[email protected]>
> > Signed-off-by: Wenyi Xie <[email protected]>
> > Reviewed-by: Laszlo Ersek <[email protected]>
> > ---
> >  SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/SecurityPkg/FvReportPei/FvReportPei.c
> > b/SecurityPkg/FvReportPei/FvReportPei.c
> > index d709760ea3ce..e82413e090c0 100644
> > --- a/SecurityPkg/FvReportPei/FvReportPei.c
> > +++ b/SecurityPkg/FvReportPei/FvReportPei.c
> > @@ -67,7 +67,7 @@ InstallPreHashFvPpi (
> >    HASH_INFO                                         *HashInfo;
> >
> >    PpiSize = sizeof
> > (EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI)
> > -            + sizeof (sizeof (HASH_INFO))
> > +            + sizeof (HASH_INFO)
> >              + HashSize;
> >
> >    PreHashedFvPpi = AllocatePool (PpiSize);
> > --
> > 2.20.1.windows.1
> >
> >
> >
> > 
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78355): https://edk2.groups.io/g/devel/message/78355
Mute This Topic: https://groups.io/mt/84523794/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to