Stefan
This patch is NOT acceptable.
> + if (1 /*PcdGetBool (PcdRandomizePlatformHierarchy)*/) {
Nacked-by: Jiewen Yao <[email protected]>
Thank you
Yao Jiewen
> -----Original Message-----
> From: Stefan Berger <[email protected]>
> Sent: Friday, August 6, 2021 11:33 PM
> To: [email protected]; Yao, Jiewen <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; Stefan Berger <[email protected]>;
> Stefan Berger <[email protected]>
> Subject: [RFC PATCH 3/7] SecurityPkg/TPM: Disable PcdGetBool
> (PcdRandomizePlatformHierarchy)
>
> To avoid this type of build errors, disable
> 'PcdGetBool (PcdRandomizePlatformHierarchy)'.
>
> Building ...
> /home/stefanb/dev/edk2/SecurityPkg/Library/SecureBootVariableProvisionLib/
> SecureBootVariableProvisionLib.inf [X64]
> In file included from
> /home/stefanb/dev/edk2/Build/OvmfX64/DEBUG_GCC5/X64/SecurityPkg/Librar
> y/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib/DEBUG/Aut
> oGen.h:17,
> from <command-line>:
> /home/stefanb/dev/edk2/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/
> PeiDxeTpmPlatformHierarchyLib.c: In function
> ‘ConfigureTpmPlatformHierarchy’:
> /home/stefanb/dev/edk2/MdePkg/Include/Library/PcdLib.h:424:45: error:
> ‘_PCD_GET_MODE_BOOL_PcdRandomizePlatformHierarchy’ undeclared (first
> use in this function)
> 424 | #define PcdGetBool(TokenName)
> _PCD_GET_MODE_BOOL_##TokenName
> | ^~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Stefan Berger <[email protected]>
> ---
> .../PeiDxeTpmPlatformHierarchyLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHier
> archyLib.c
> b/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHier
> archyLib.c
> index 9812ab99ab..bea10d37a4 100644
> ---
> a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHier
> archyLib.c
> +++
> b/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHier
> archyLib.c
> @@ -252,7 +252,7 @@ EFIAPI
> ConfigureTpmPlatformHierarchy (
>
> )
>
> {
>
> - if (PcdGetBool (PcdRandomizePlatformHierarchy)) {
>
> + if (1 /*PcdGetBool (PcdRandomizePlatformHierarchy)*/) {
>
> //
>
> // Send Tpm2HierarchyChange Auth with random value to avoid PlatformAuth
> being null
>
> //
>
> --
> 2.31.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78842): https://edk2.groups.io/g/devel/message/78842
Mute This Topic: https://groups.io/mt/84712028/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
