Yes. I'm ok to add the proposed patches to edk2-staging repository. Reviewed-by: Steven Shi <steven....@intel.com>
Thanks > -----Original Message----- > From: Kinney, Michael D <michael.d.kin...@intel.com> > Sent: Friday, August 20, 2021 12:26 AM > To: Shi, Steven <steven....@intel.com>; devel@edk2.groups.io; Kinney, > Michael D <michael.d.kin...@intel.com> > Cc: gaolim...@byosoft.com.cn; Feng, Bob C <bob.c.f...@intel.com>; > yuqi.c...@mail.utoronto.ca; Chen, Christine <yuwei.c...@intel.com> > Subject: RE: [BaseTools Patch 0/2] Add clang/gnumake build support in > windows > > Hi Steven, > > Thank you for helping send the patches. > > I think the request is to add the > https://github.com/alyssachne/edk2/tree/2021-gsoc-llvm-gnumake-v3 > branch to edk2-staging repository once the review of these 2 patches are > complete. Correct? > > That branch is based on very recent edk2/master with 2 patches added to > address CLANG compatibility issues. > > The EDK II community needs to evaluate these changes and they would be > moved from > edk2-staging to edk2/master after the next edk2-stable tag. > > If you agree with the proposed patches, can you provide a Rb? > > I would also be good if the current BaseToools maintainers/reviewers also > provide > their feedback and Rb if they agree with the changes. > > Thanks, > > Mike > > > -----Original Message----- > > From: Shi, Steven <steven....@intel.com> > > Sent: Wednesday, August 18, 2021 7:19 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; > gaolim...@byosoft.com.cn; Feng, Bob C <bob.c.f...@intel.com>; > > yuqi.c...@mail.utoronto.ca; Shi, Steven <steven....@intel.com> > > Subject: [BaseTools Patch 0/2] Add clang/gnumake build support in > windows > > > > Google Summer of Code 2021 project: Add clang + gnu make build support > > for Edk2 BaseTools in windows > > > > Details of tool combinations and build steps: > > https://github.com/alyssachne/edk2/tree/2021-gsoc-llvm-gnumake-v3 > > > > Only plan to check-in to edk2-staging right now > > > > Help to send this patch serial for Yuqi Chen <yuqi.c...@mail.utoronto.ca>, > > since she has git configure problem. > > > > Alyssa (2): > > BaseTools: add clang + gnu make build support in windows > > Readme: Update the readme to add project details > > > > BaseTools/Source/C/BrotliCompress/GNUmakefile | 8 +- > > BaseTools/Source/C/Common/CommonLib.h | 9 + > > BaseTools/Source/C/Common/MyAlloc.c | 4 +- > > BaseTools/Source/C/Common/MyAlloc.h | 4 +- > > BaseTools/Source/C/DevicePath/GNUmakefile | 6 +- > > BaseTools/Source/C/EfiRom/GNUmakefile | 6 +- > > BaseTools/Source/C/GNUmakefile | 74 ++- > > BaseTools/Source/C/GenCrc32/GNUmakefile | 6 +- > > BaseTools/Source/C/GenFfs/GNUmakefile | 6 +- > > BaseTools/Source/C/GenFv/GNUmakefile | 6 +- > > BaseTools/Source/C/GenFw/GNUmakefile | 6 +- > > BaseTools/Source/C/GenSec/GNUmakefile | 6 +- > > BaseTools/Source/C/LzmaCompress/GNUmakefile | 6 +- > > BaseTools/Source/C/Makefiles/app.makefile | 5 +- > > BaseTools/Source/C/Makefiles/header.makefile | 84 ++- > > BaseTools/Source/C/Makefiles/lib.makefile | 6 +- > > BaseTools/Source/C/Makefiles/ms.app | 2 +- > > BaseTools/Source/C/Makefiles/ms.common | 9 + > > BaseTools/Source/C/TianoCompress/GNUmakefile | 6 +- > > BaseTools/Source/C/VfrCompile/GNUmakefile | 29 +- > > .../C/VfrCompile/Pccts/antlr/AntlrMS.mak | 9 +- > > .../Source/C/VfrCompile/Pccts/antlr/makefile | 7 + > > .../Source/C/VfrCompile/Pccts/dlg/DlgMS.mak | 9 +- > > .../Source/C/VfrCompile/Pccts/dlg/makefile | 7 + > > BaseTools/Source/C/VolInfo/GNUmakefile | 6 +- > > BaseTools/Tests/GNUmakefile | 17 +- > > BaseTools/Tests/TestTools.py | 2 +- > > BaseTools/Tests/TianoCompress.py | 5 +- > > BaseTools/toolsetup.bat | 14 +- > > ReadMe.rst | 553 ++++++------------ > > edksetup.bat | 7 +- > > 31 files changed, 457 insertions(+), 467 deletions(-) > > > > -- > > 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79639): https://edk2.groups.io/g/devel/message/79639 Mute This Topic: https://groups.io/mt/84973009/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
