On September 28, 2021 12:43 PM, Gerd Hoffmann wrote: > Hi, > > > > Can you move the metadata changes to a separate patch please? > > Yes, the metadata changes will be in a separate patch in the next version. > > Can you also add a comment block documenting the format? Not only those > parts which are used for TDVF, but everything? The description in > tdx-virtual- > firmware-design-guide-rev-1.pdf seems to be incomplete, specifically the > option to use the table for TD memory allocation (as mentioned by Jiewen) is > not covered. And possibly there is more which is missing ... Sure. I will add the comment in IntelTdxMetadata.asm to describe the format of Tdx Metadata. Here is the PR I would send as the next version. https://github.com/tianocore/edk2/pull/2018 You can have a preliminary review if you want. > > thanks, > Gerd > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81206): https://edk2.groups.io/g/devel/message/81206 Mute This Topic: https://groups.io/mt/85891884/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
