On October 29, 2021 10:06 AM, Liming Gao wrote: > Min: > I add my comments below. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 > > > > Why adds MdePkg/Include/Protocol/TdProtocol.h? Can combine it into > MdePkg/Include/Protocol/TeeMeasurement.h? I once thought TdProtocol.h includes the TDX specific defitions, while TeeMeasurement.h contains the neutral ones. I will squash TdProtocol.h to TeeMeasurement.h in the next version. > > > + > > +#include <Uefi/UefiBaseType.h> > > Uefi/UefiBaseType.h is not required to be included. Module header file has > includes it. Thanks for reminder. It will be removed in the next version. > > > gEfiTeeFinalEventsTableGuid is not declared in MdePkg.dec. Then, how does > the module consume it? Sorry for the error. It should be declared in MdePkg.dec. Thanks for the reminder. >
Thanks. Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82896): https://edk2.groups.io/g/devel/message/82896 Mute This Topic: https://groups.io/mt/86668869/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
