Thank you for the review, Liming. Since uploading the original patch series I noticed some issues myself and have sent a v2 for the patch series (https://edk2.groups.io/g/devel/message/83272). I have not made any MdePkg changes, so I assume your review carries over to the new series?
Thanks, Chris ________________________________ From: gaoliming <gaolim...@byosoft.com.cn> Sent: Tuesday, November 2, 2021 1:23 AM To: devel@edk2.groups.io <devel@edk2.groups.io>; Christopher Jones <christopher.jo...@arm.com> Cc: michael.d.kin...@intel.com <michael.d.kin...@intel.com>; zhiguang....@intel.com <zhiguang....@intel.com>; ray...@intel.com <ray...@intel.com>; zhichao....@intel.com <zhichao....@intel.com>; Alexei Fedorov <alexei.fedo...@arm.com>; Sami Mujawar <sami.muja...@arm.com>; nd <n...@arm.com> Subject: 回复: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes For the changes in MdePkg, Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Chris Jones > 发送时间: 2021年10月18日 23:11 > 收件人: devel@edk2.groups.io > 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn; > zhiguang....@intel.com; ray...@intel.com; zhichao....@intel.com; > alexei.fedo...@arm.com; sami.muja...@arm.com; n...@arm.com > 主题: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes > > Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) > > This patch series updates the Acpiview PPTT parser and DynamicTablesPkg > PPTT generator to support ACPI 6.4. This consists of two main changes: > - The addition of the 'Cache ID' field. > - The removal of the PPTT ID (type 2) structure. > > In addition add two 'Cache ID' defines and remove the type 2 PPTT > structure from Acpi64.h as these changes were missing when Acpi64.h was > introduced. > > The changes can be seen at: > https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v1 > > Chris Jones (7): > MdePkg: Add missing Cache ID (in)valid define > MdePkg: Remove PPTT ID type structure > ShellPkg: Update Acpiview PPTT parser to ACPI 6.4 > ShellPkg: Add Cache ID to PPTT parser > DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator > DynamicTablesPkg: Update PPTT generator to ACPI 6.4 > DynamicTablesPkg: Add CacheId to PPTT generator > > .../Include/ArmNameSpaceObjects.h | 27 +- > .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 297 +++++++----------- > .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h | 4 - > MdePkg/Include/IndustryStandard/Acpi64.h | 18 +- > .../Parsers/Pptt/PpttParser.c | 179 ++++++++--- > .../UefiShellAcpiViewCommandLib.c | 2 +- > 6 files changed, 249 insertions(+), 278 deletions(-) > > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83281): https://edk2.groups.io/g/devel/message/83281 Mute This Topic: https://groups.io/mt/86795239/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
