Min: > -----邮件原件----- > 发件人: [email protected] <[email protected]> 代表 Min Xu > 发送时间: 2021年11月4日 20:35 > 收件人: [email protected]; [email protected] > 抄送: Kinney, Michael D <[email protected]>; Liu, Zhiguang > <[email protected]>; Yao, Jiewen <[email protected]>; Wang, Jian J > <[email protected]>; Lu, Ken <[email protected]>; 'Sami Mujawar' > <[email protected]>; 'Gerd Hoffmann' <[email protected]> > 主题: Re: [edk2-devel] 回复: [PATCH V4 1/3] MdePkg: Introduce > CcMeasurementProtocol for CC Guest firmware > > On November 4, 2021 1:51 PM, Gao, Liming wrote: > > Min: > > I have one minor comment. gEfiCcFinalEventsTableGuid may be placed > into > > [Guids] section instead of [Protocols] section. > > > Hi, Liming > I follow the definition of gEfiTcg2ProtocolGuid and > gEfiTcg2FinalEventsTableGuid. See > https://github.com/tianocore/edk2/blob/master/MdePkg/MdePkg.dec#L159 > 0-L1592 > Actually gEfiCcMeasurementProtocolGuid and gEfiCcFinalEventsTableGuid are > the counterpart protocol/guid definition in Confidential Computing measure > boot. > I am not sure if there is some other consideration that gEfiTcg2ProtocolGuid > and gEfiTcg2FinalEventsTableGuid are defined in the section of [Protocols]. I find gEfiTcg2FinalEventsTableGuid is used for configuration table. This is one Guid usage. It should be placed into [Guids] section.
You can see hash protocol and hash algorithm guid in MdePkg. gEfiHashProtocolGuid is defined in [Protocols] section, and gEfiHashAlgorithmMD5Guid is defined in [Guids] section. They are both from MdePkg/Include/Protocol/Hash.h. So, I suggest to follow the guid usage to define this Guid into the different section. Thanks Liming > > Thanks > Min > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83366): https://edk2.groups.io/g/devel/message/83366 Mute This Topic: https://groups.io/mt/86834400/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
