On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote:
> Hi,
>
> > 3. Require use of uncrustify tool before submitting patch review emails
> > or PRs.
> > * The required version would be a formally released version from
> > the fork maintained by Michael Kubacki until the changes can be upstreamed.
> > * https://dev.azure.com/projectmu/Uncrustify
>
> Can we please *first* get the changes merged to upstream uncrustify?
>
> That'll make the whole process much less painful because the usual
> software repositories (linux distro packages, macos homebrew, ...)
> can be used to install uncrustify then, and it's also less confusing if
> developers don't have to juggle with different uncrustify variants
> (upstream vs. edk2).
Whilst I agree in principle...
This means postponing automated coding style changes until 2023
(Debian stable), 2025 (Ubuntu LTS), ??? (RHEL10), or even later
... and I'd rather not.
I like Marvin's suggestion of a submodule. Which we could drop once
no longer needed.
/
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83509): https://edk2.groups.io/g/devel/message/83509
Mute This Topic: https://groups.io/mt/84932137/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
