[edk2-devel] [PATCH edk2-platforms v1 05/10] Platform/ARM: Fix Ecc error 1001

[PierreGondois]

From: Pierre Gondois <pierre.gond...@arm.com>

This patch fixes the following Ecc reported error:
'TAB' character is not allowed in source code,
please replace each 'TAB' with two spaces.

The patch also format and document the InstallStructures
function to comply to edk2 coding style.

Signed-off-by: Pierre Gondois <pierre.gond...@arm.com>
---
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.c     | 38 ++++++++++---------
 .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h       |  4 +-
 2 files changed, 23 insertions(+), 19 deletions(-)

diff --git a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c 
b/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
index ac18b16ca676..a5a675b2a613 100644
--- a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
+++ b/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
@@ -743,36 +743,40 @@ InstallMemoryStructure (
 }

 /**
-   Install a whole table worth of structructures
+  Install a whole table worth of structures.

-   @parm
+  @param [in] Smbios         Smbios protocol.
+  @param [in] DefaultTables  Default Smbios tables.
+
+  @retval EFI_SUCCESS           Record was added.
+  @retval EFI_OUT_OF_RESOURCES  Record was not added.
+  @retval EFI_ALREADY_STARTED   The SmbiosHandle passed in was already in use.
 **/
 EFI_STATUS
 InstallStructures (
-   IN EFI_SMBIOS_PROTOCOL       *Smbios,
-   IN CONST VOID *DefaultTables[]
+   IN EFI_SMBIOS_PROTOCOL   *Smbios,
+   IN CONST VOID            *DefaultTables[]
    )
 {
     EFI_STATUS                Status = EFI_SUCCESS;
     EFI_SMBIOS_HANDLE         SmbiosHandle;
+    UINTN                     TableEntry;

-    int TableEntry;
-    for ( TableEntry=0; DefaultTables[TableEntry] != NULL; TableEntry++)
-    {
-       SmbiosHandle = 
((EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntry])->Handle;
-       Status = Smbios->Add (
-           Smbios,
-           NULL,
-           &SmbiosHandle,
-           (EFI_SMBIOS_TABLE_HEADER*) DefaultTables[TableEntry]
-           );
-       if (EFI_ERROR(Status))
-           break;
+    for (TableEntry = 0; DefaultTables[TableEntry] != NULL; TableEntry++) {
+      SmbiosHandle = 
((EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntry])->Handle;
+      Status = Smbios->Add (
+                         Smbios,
+                         NULL,
+                         &SmbiosHandle,
+                         (EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntry]
+                         );
+      if (EFI_ERROR(Status)) {
+        break;
+      }
     }
     return Status;
 }

-
 /**
    Install all structures from the DefaultTables structure

diff --git a/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h 
b/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h
index 601714c94387..e50c458f8c3a 100644
--- a/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h
+++ b/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h
@@ -45,7 +45,7 @@ Lan9118RawMmioRead32(
   UINTN Delay
   );
 #define Lan9118MmioRead32(a) \
-       Lan9118RawMmioRead32(a, a ## _RD_DELAY)
+  Lan9118RawMmioRead32(a, a ## _RD_DELAY)

 UINT32
 Lan9118RawMmioWrite32(
@@ -54,7 +54,7 @@ Lan9118RawMmioWrite32(
   UINTN Delay
   );
 #define Lan9118MmioWrite32(a, v) \
-       Lan9118RawMmioWrite32(a, v, a ## _WR_DELAY)
+  Lan9118RawMmioWrite32(a, v, a ## _WR_DELAY)

 /* ------------------ MAC CSR Access ------------------- */

--
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84048): https://edk2.groups.io/g/devel/message/84048
Mute This Topic: https://groups.io/mt/87284490/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-