Hi Gerd,
To help me understand which files you're specifically referring to, can
you please point them out from this commit? Or provide additional details?
https://github.com/tianocore/edk2/pull/2229/commits/50654dfe5785964c9ae72961d13a50b26af77794
CryptoPkg/Library/Include/openssl/opensslconf.h is currently formatted.
Regards,
Michael
On 12/2/2021 6:00 AM, Gerd Hoffmann wrote:
On Wed, Dec 01, 2021 at 12:05:24PM -0500, Michael Kubacki wrote:
This can of course be done at a technical level but it smells of a code
cohesion problem.
The code is in the edk2 project so it would reason that it should be uniform
in style with other code and at least close to the EDK II C Coding Standard
Specification.
Currently, git submodules and ignored path are already excluded in addition
to the ability to mark packages in "audit mode" so they do not fail the
results. I would personally prefer not to allow arbitrary subdirectories to
diverge from the rest of the codebase / package but if there's consensus
this is a good idea, I can look into adding it.
What is the plan for generated include files, for example the ones in
CryptoPkg/Library/Include/openssl?
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84250): https://edk2.groups.io/g/devel/message/84250
Mute This Topic: https://groups.io/mt/87414953/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
