On Mon, Dec 13, 2021 at 08:57:01PM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 > > Discussion in https://bugzilla.tianocore.org/show_bug.cgi?id=1496 shows > that 8254TimerDxe was not written for OVMF. It was moved over from > PcAtChipsetPkg to OvmfPkg in 2019. Probably because OVMF was the only > user left. > > Most likely the reason OVMF used 8254TimerDxe initially was that it could > just use the existing driver in PcAtChipsetPkg. And it simply hasn't > been changed ever. > > CSM support was moved in 2019 too. (CSM support depends on 8254/8259 > drivers). So 8254TimerDxe will be used when CSM_ENABLE=TRUE. > > There are 4 .dsc which include the 8254Timer. > - OvmfPkg/AmdSev/AmdSevX64.dsc > - OvmfPkg/OvmfPkgIa32.dsc > - OvmfPkg/OvmfPkgIa32X64.dsc > - OvmfPkg/OvmfPkgX64.dsc > > For the three OvmfPkg* configs using 8254TimerDxe with CSM_ENABLE=TRUE > and LapicTimerDxe otherwise. > > For the AmdSev config it doesn't make sense to support a CSM. So use > the lapic timer unconditionally. > > Cc: Ard Biesheuvel <[email protected]> > Cc: Jordan Justen <[email protected]> > Cc: Brijesh Singh <[email protected]> > Cc: Erdem Aktas <[email protected]> > Cc: James Bottomley <[email protected]> > Cc: Jiewen Yao <[email protected]> > Cc: Tom Lendacky <[email protected]> > Cc: Gerd Hoffmann <[email protected]> > Suggested-by: Gerd Hoffmann <[email protected]> > Signed-off-by: Min Xu <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84886): https://edk2.groups.io/g/devel/message/84886 Mute This Topic: https://groups.io/mt/87696610/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
