Hello Rebecca, The patch looks good to me,
Reviewed-by: Pierre Gondois <pierre.gond...@arm.com> On 1/8/22 10:57 PM, Rebecca Cran via groups.io wrote: > In AmlCodeGenReturn, the cast to AML_NODE_HEADER* in the call to > AmlSetFixedArgument is redundant because ReturnNode is already a > AML_NODE_HEADER* . > > Signed-off-by: Rebecca Cran <quic_rc...@quicinc.com> > --- > DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > index d245848ce3fa..838a892c6b58 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > @@ -1564,7 +1564,7 @@ AmlCodeGenReturn ( > Status = AmlSetFixedArgument ( > ObjectNode, > EAmlParseIndexTerm0, > - (AML_NODE_HEADER *)ReturnNode > + ReturnNode > ); > if (EFI_ERROR (Status)) { > ASSERT (0); -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85540): https://edk2.groups.io/g/devel/message/85540 Mute This Topic: https://groups.io/mt/88291890/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-