Hi Min,
Would you please create a PR for this and point me to the link?
Thanks
Abner
________________________________
From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, January 25, 2022 11:09 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; min.m...@intel.com
<min.m...@intel.com>
Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in
FwVol.c in X64 arch
Reviewed-by: Abner Chang <abner.ch...@hpe.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Min Xu
> Sent: Tuesday, January 25, 2022 2:33 PM
> To: devel@edk2.groups.io
> Cc: Min Xu <min.m...@intel.com>; Leif Lindholm <l...@nuviainc.com>; Ard
> Biesheuvel <ardb+tianoc...@kernel.org>; Chang, Abner (HPS SW/FW
> Technologist) <abner.ch...@hpe.com>; Schaefer, Daniel (ROM Janitor)
> <daniel.schae...@hpe.com>
> Subject: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in
> FwVol.c in X64 arch
>
> RFC:
> INVALID URI REMOVED
> d=3429__;!!NpxR!xMRxJim2LXdgV0CClUrT7jWBUouLzrVwMc5fB_wt1PT17W
> WWyZKgREYswYM1Tz0$
>
> CompressedDataLength is declared as UINTN which is UINT64 in X64 arch.
> But the second parameter of UefiDecompressGetInfo() is declared as
> UINT32. So a build error is triggered. To declare CompressedDataLength
> as UINT32 to fix the build error.
>
> Cc: Leif Lindholm <l...@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
> Cc: Abner Chang <abner.ch...@hpe.com>
> Cc: Daniel Schaefer <daniel.schae...@hpe.com>
> Signed-off-by: Min Xu <min.m...@intel.com>
> ---
> EmbeddedPkg/Library/PrePiLib/FwVol.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c
> b/EmbeddedPkg/Library/PrePiLib/FwVol.c
> index 92ae68f0d382..0a6d6925b7ea 100644
> --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c
> +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c
> @@ -291,7 +291,7 @@ FfsProcessSection (
> UINT16 SectionAttribute;
> UINT32 AuthenticationStatus;
> CHAR8 *CompressedData;
> - UINTN CompressedDataLength;
> + UINT32 CompressedDataLength;
>
> *OutputBuffer = NULL;
> ParsedLength = 0;
> @@ -320,7 +320,7 @@ FfsProcessSection (
> }
>
> CompressedData = (CHAR8 *)((EFI_COMPRESSION_SECTION2
> *)Section + 1);
> - CompressedDataLength = (UINT32)SectionLength - sizeof
> (EFI_COMPRESSION_SECTION2);
> + CompressedDataLength = SectionLength - sizeof
> (EFI_COMPRESSION_SECTION2);
> } else {
> CompressionSection = (EFI_COMPRESSION_SECTION *)Section;
> SectionLength = SECTION_SIZE (Section);
> @@ -330,7 +330,7 @@ FfsProcessSection (
> }
>
> CompressedData = (CHAR8 *)((EFI_COMPRESSION_SECTION
> *)Section + 1);
> - CompressedDataLength = (UINT32)SectionLength - sizeof
> (EFI_COMPRESSION_SECTION);
> + CompressedDataLength = SectionLength - sizeof
> (EFI_COMPRESSION_SECTION);
> }
>
> Status = UefiDecompressGetInfo (
> --
> 2.29.2.windows.2
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86094): https://edk2.groups.io/g/devel/message/86094
Mute This Topic: https://groups.io/mt/88666799/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
