Thanks for the reminder. Apparently, I missed Gerd's feedback. His reply is 
buried with another patch set he sent in my mailbox.

Abner
________________________________
From: Ard Biesheuvel <a...@kernel.org>
Sent: Saturday, January 29, 2022 2:06 AM
To: edk2-devel-groups-io <devel@edk2.groups.io>; Chang, Abner (HPS SW/FW 
Technologist) <abner.ch...@hpe.com>
Cc: Schaefer, Daniel (ROM Janitor) <daniel.schae...@hpe.com>; Sunil V L 
<suni...@ventanamicro.com>; Ard Biesheuvel <ardb+tianoc...@kernel.org>; Jiewen 
Yao <jiewen....@intel.com>; Jordan Justen <jordan.l.jus...@intel.com>; Gerd 
Hoffmann <kra...@redhat.com>; Leif Lindholm <l...@nuviainc.com>; Sami Mujawar 
<sami.muja...@arm.com>
Subject: Re: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg 
BaseCachingPciExpressLib

On Fri, 28 Jan 2022 at 17:14, Abner Chang <abner.ch...@hpe.com> wrote:
>
> Hi package owners,
> Please take a look at this patch, this patch moves ArmVirtPkg 
> BaseCachingPciExpressLib to OvmfPkg for OvmfRiscV64.
>

Do you intend to incorporate Gerd's feedback?

>
> ________________________________
> From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Abner Chang 
> <abner.ch...@hpe.com>
> Sent: Monday, January 24, 2022 9:52 PM
> To: devel@edk2.groups.io <devel@edk2.groups.io>
> Cc: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>; Schaefer, 
> Daniel (ROM Janitor) <daniel.schae...@hpe.com>; Sunil V L 
> <suni...@ventanamicro.com>; Ard Biesheuvel <ardb+tianoc...@kernel.org>; 
> Jiewen Yao <jiewen....@intel.com>; Jordan Justen <jordan.l.jus...@intel.com>; 
> Gerd Hoffmann <kra...@redhat.com>; Leif Lindholm <l...@nuviainc.com>; Sami 
> Mujawar <sami.muja...@arm.com>
> Subject: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg BaseCachingPciExpressLib
>
> Clone BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg.
> RISC-V Virt platform can leverage the same library to access PCI Express
> registers through PCI Express base address set in PcdPciExpressBaseAddress
> and cached in a global variable. Also remove the one under ArmVirtPkg.
>
> Signed-off-by: Abner Chang <abner.ch...@hpe.com>
> Cc: Daniel Schaefer <daniel.schae...@hpe.com>
> Cc: Sunil V L <suni...@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
> Cc: Jiewen Yao <jiewen....@intel.com>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Gerd Hoffmann <kra...@redhat.com>
> Cc: Leif Lindholm <l...@nuviainc.com>
> Cc: Sami Mujawar <sami.muja...@arm.com>
>
> Abner Chang (2):
>   OvmfPkg/BaseCachingPciExpressLib: Clone ArmVirtPkg
>     BaseCachingPciExpressLib
>   ArmVirtPkg/BaseCachingPciExpressLib: Remove BaseCachingPciExpressLib
>
>  ArmVirtPkg/ArmVirt.dsc.inc                                  | 2 +-
>  ArmVirtPkg/ArmVirtKvmTool.dsc                               | 6 +++---
>  .../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf   | 5 +++--
>  .../Library/BaseCachingPciExpressLib/PciExpressLib.c        | 0
>  4 files changed, 7 insertions(+), 6 deletions(-)
>  rename {ArmVirtPkg => 
> OvmfPkg}/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf (87%)
>  rename {ArmVirtPkg => 
> OvmfPkg}/Library/BaseCachingPciExpressLib/PciExpressLib.c (100%)
>
> --
> 2.31.1
>
>
>
>
>
>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86205): https://edk2.groups.io/g/devel/message/86205
Mute This Topic: https://groups.io/mt/88647809/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to