> -----Original Message----- > From: Ard Biesheuvel <a...@kernel.org> > Sent: Sunday, January 30, 2022 1:17 AM > To: edk2-devel-groups-io <devel@edk2.groups.io>; Chang, Abner (HPS > SW/FW Technologist) <abner.ch...@hpe.com> > Cc: Schaefer, Daniel (ROM Janitor) <daniel.schae...@hpe.com>; Sunil V L > <suni...@ventanamicro.com>; Ard Biesheuvel <ardb+tianoc...@kernel.org>; > Jiewen Yao <jiewen....@intel.com>; Jordan Justen > <jordan.l.jus...@intel.com>; Gerd Hoffmann <kra...@redhat.com>; Leif > Lindholm <l...@nuviainc.com>; Sami Mujawar <sami.muja...@arm.com> > Subject: Re: [edk2-devel] [PATCH v2 2/2] > OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf > > On Sat, 29 Jan 2022 at 18:05, Abner Chang <abner.ch...@hpe.com> wrote: > > > > Remove the dependency with ArmVirtPkg and add RISCV64 in > VALID_ARCHITECTURES. > > > > Signed-off-by: Abner Chang <abner.ch...@hpe.com> > > Cc: Daniel Schaefer <daniel.schae...@hpe.com> > > Cc: Sunil V L <suni...@ventanamicro.com> > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > Cc: Jiewen Yao <jiewen....@intel.com> > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > Cc: Gerd Hoffmann <kra...@redhat.com> > > Cc: Leif Lindholm <l...@nuviainc.com> > > Cc: Sami Mujawar <sami.muja...@arm.com> > > --- > > .../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > a/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > > index 33568f568f..0383a37cbf 100644 > > --- > a/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > > +++ > b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > > @@ -21,15 +21,15 @@ > > CONSTRUCTOR = PciExpressLibInitialize > > > > # > > -# VALID_ARCHITECTURES = ARM AARCH64 > > +# VALID_ARCHITECTURES = ARM AARCH64 RISCV64 > > # > > > > I am going to fold the above hunk into patch #1, given that > > > [Sources] > > PciExpressLib.c > > > > [Packages] > > - ArmVirtPkg/ArmVirtPkg.dec > > MdePkg/MdePkg.dec > > + OvmfPkg/OvmfPkg.dec > > > > this change is unnecessary - either package reference is unnecessary > so I will just drop the reference to ArmVirtPkg/ArmVirtPkg.dec when > moving it. [Abner] Thanks. Yes, adding OvmfPkg is redundant.
BTW, I saw CI reported the errors on this merge. However, those errors seem irrelevant to the code changes. Does that matter? https://github.com/tianocore/edk2/runs/4992385347 Abner > > > [LibraryClasses] > > BaseLib > > -- > > 2.31.1 > > > > > > > > ------------ > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#86214): > https://edk2.groups.io/g/devel/message/86214 > > Mute This Topic: https://groups.io/mt/88770183/5717338 > > Group Owner: devel+ow...@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [ardb+tianoc...@kernel.org] > > ------------ > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86223): https://edk2.groups.io/g/devel/message/86223 Mute This Topic: https://groups.io/mt/88770183/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
