Pushed as e3e2e71b0a..5757dceecb

-----Original Message-----
From: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com> 
Sent: Monday, February 14, 2022 11:05 PM
To: Oram, Isaac W <isaac.w.o...@intel.com>; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Gao, Liming 
<gaolim...@byosoft.com.cn>
Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1] BeepDebugFeaturePkg: 
Enable FixedAtBuild PCD type

Reviewed-by: Sai Chaganty <rangasai.v.chaga...@intel.com>

-----Original Message-----
From: Oram, Isaac W <isaac.w.o...@intel.com> 
Sent: Friday, February 11, 2022 4:13 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Desimone, Nathaniel L 
<nathaniel.l.desim...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] BeepDebugFeaturePkg: Enable 
FixedAtBuild PCD type

Enable PcdStatusCodeUseBeep to allow FixedAtBuild type for backwards 
compatibility.

Cc: Sai Chaganty <rangasai.v.chaga...@intel.com>
Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Signed-off-by: Isaac Oram <isaac.w.o...@intel.com>
---
 Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dec | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dec 
b/Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dec
index d90611da51..9f44f228d1 100644
--- a/Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dec
+++ b/Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.d
+++ ec
@@ -34,6 +34,5 @@
 [PcdsFeatureFlag]
   
gBeepDebugFeaturePkgTokenSpaceGuid.PcdBeepDebugFeatureEnable|FALSE|BOOLEAN|0x00000000
 
-[PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
-  # Beep is a legacy feature, disabled it by default
+[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
   
gBeepDebugFeaturePkgTokenSpaceGuid.PcdStatusCodeUseBeep|TRUE|BOOLEAN|0x00000001
--
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86686): https://edk2.groups.io/g/devel/message/86686
Mute This Topic: https://groups.io/mt/89084754/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to