On March 1, 2022 9:27 PM, Gerd Hoffmann wrote:
>
> > @@ -15,6 +15,22 @@
> > typedef struct {
> > EFI_HOB_GUID_TYPE GuidHeader;
> > UINT16 HostBridgePciDevId;
> > + BOOLEAN PcdSetNxForStack;
> > +
> > + UINT64 PcdConfidentialComputingGuestAttr;
> > + BOOLEAN PcdIa32EferChangeAllowed;
> > + UINT64 PcdTdxSharedBitMask;
> > +
> > + UINT64 PcdPciMmio64Base;
> > + UINT64 PcdPciMmio64Size;
> > + UINT32 PcdPciMmio32Base;
> > + UINT32 PcdPciMmio32Size;
> > + UINT64 PcdPciIoBase;
> > + UINT64 PcdPciIoSize;
>
> Ah, here you add some of them to PLATFORM_INFO already ...
>
Actually there are 2 stages of EFI_HOB_PLATFORM_INFO.
The first stage is in Config-A (see
https://github.com/mxu9/edk2/commit/30bdad7da340cb390c4a3ce0f49fc4324b72e60f).
In this patch the EFI_HOB_PLATFORM_INFO is very simple. There are only 2 fields
(GuidHeader + HostBridgePciDevId). Because Config-A boots with PEI and PCDs are
set in OvmfPkg/PlatformPei. So we don't need to ask EFI_HOB_PLATFORM_INFO to
carry other information.
Then we come to Config-B (the Pei-less boot). PCDs cannot be set in SEC phase.
So we have to make EFI_HOB_PLATFORM_INFO to carry more information. See
https://github.com/mxu9/edk2/commit/a1779386899369eb9c27517d72cc49870fd78b45
Since you're asking to simply pass around a EFI_HOB_PLATFORM_INFO pointer to
the functions in PlatformInitLib, I am ok to define the complete
EFI_HOB_PLATFORM_INFO structure in one patch.
Thanks
Min
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87177): https://edk2.groups.io/g/devel/message/87177
Mute This Topic: https://groups.io/mt/89446691/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
