Hi Min,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 02/03/2022 12:28 AM, Min Xu wrote:
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the
event-log information. The event log created by the TD owner contains
the hashes to reconstruct the MRTD and RTMR registers.
Please refer to Sec 4.3.3 in blow link:
https://www.intel.com/content/dam/develop/external/us/en/documents/
intel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang....@intel.com>
Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Jian J Wang <jian.j.w...@intel.com>
Cc: Ken Lu <ken...@intel.com>
Cc: Sami Mujawar <sami.muja...@arm.com>
Cc: Gerd Hoffmann <kra...@redhat.com>
Signed-off-by: Min Xu <min.m...@intel.com>
---
MdePkg/Include/Protocol/CcMeasurement.h | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/MdePkg/Include/Protocol/CcMeasurement.h
b/MdePkg/Include/Protocol/CcMeasurement.h
index 83eaafaf10a6..86de226c1d82 100644
--- a/MdePkg/Include/Protocol/CcMeasurement.h
+++ b/MdePkg/Include/Protocol/CcMeasurement.h
@@ -307,4 +307,24 @@ extern EFI_GUID gEfiCcFinalEventsTableGuid;
extern EFI_GUID gCcEventEntryHobGuid;
+//
+// Define the CC Measure EventLog ACPI Table
+//
+#pragma pack(1)
+
+typedef struct {
+ EFI_ACPI_DESCRIPTION_HEADER Header;
+ UINT32 Rsvd;
+ UINT64 Laml;
+ UINT64 Lasa;
+} EFI_CC_EVENTLOG_ACPI_TABLE;
+
+#pragma pack()
+
+//
+// Define the signature and revision of CC Measurement EventLog ACPI Table for
Td guest
+//
+#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_SIGNATURE SIGNATURE_32('T', 'D', 'E',
'L')
+#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_REVISION 1
[SAMI] I can see that the above macros have the _TD_ infix. Is the
intention here that each architecture shall define its own signature and
revision?
Would it be possible to make the signature generic across architectures,
e.g. "SIGNATURE_32('C', 'C', 'E', 'L')" ?
[/SAMI]
+
#endif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87391): https://edk2.groups.io/g/devel/message/87391
Mute This Topic: https://groups.io/mt/89491522/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
