OK. Having implementation in .h is not allowed in EDKII. Sorry, I missed that.
Please move it to CrtWrapper.c and drop inline. > -----Original Message----- > From: Gerd Hoffmann <kra...@redhat.com> > Sent: Monday, April 11, 2022 2:59 PM > To: Yao, Jiewen <jiewen....@intel.com> > Cc: devel@edk2.groups.io; Oliver Steffen <ostef...@redhat.com>; Jiang, > Guomin <guomin.ji...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > Xiaoyu Lu <xiaoyux...@intel.com>; Pawel Polawski <ppola...@redhat.com> > Subject: Re: [PATCH v2 7/8] CryptoPkg/CrtLibSupport: fix strcpy > > On Fri, Apr 08, 2022 at 12:18:17PM +0000, Yao, Jiewen wrote: > > Can we remove inline keyword? > > > > I don't think it is really needed in EDKII project. > > Well, in the header file it is, otherwise we'll get duplicate symbol > errors. > > We could probably move the implementation from > CryptoPkg/Library/Include/CrtLibSupport.h to > CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c, > then drop the inline keyword. > > take care, > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88688): https://edk2.groups.io/g/devel/message/88688 Mute This Topic: https://groups.io/mt/90333060/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
