On June 7, 2022 6:40 PM, Gerd Hoffmann wrote: > On Mon, Jun 06, 2022 at 10:59:50AM +0800, Min Xu wrote: > > --- a/MdePkg/Include/Pi/PiHob.h > > +++ b/MdePkg/Include/Pi/PiHob.h > > @@ -232,7 +232,16 @@ typedef UINT32 EFI_RESOURCE_TYPE; #define > > EFI_RESOURCE_MEMORY_MAPPED_IO_PORT 0x00000004 > > #define EFI_RESOURCE_MEMORY_RESERVED 0x00000005 > > #define EFI_RESOURCE_IO_RESERVED 0x00000006 > > -#define EFI_RESOURCE_MAX_MEMORY_TYPE 0x00000007 > > +// > > +// EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted > memory. > > +// But this defitinion has not been officially in the PI spec. Base > > +// on the code-first we define EFI_RESOURCE_MEMORY_UNACCEPTED at > // > > +MdeModulePkg/Include/Pi/PrePiHob.h and update > > +EFI_RESOURCE_MAX_MEMORY_TYPE // to 8. After > > +EFI_RESOURCE_MEMORY_UNACCEPTED is officially published // in PI > spec, we will re-visit here. > > +// > > +// #define EFI_RESOURCE_MEMORY_UNACCEPTED 0x00000007 > > +#define EFI_RESOURCE_MAX_MEMORY_TYPE 0x00000008 > > Shouldn't this be handled in PrePiHob.h too? > i.e. update EFI_RESOURCE_MAX_MEMORY_TYPE with #undef + #define > there? > @Gao, Liming is the MdePkg maintainer. What's your thought, Liming?
Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90309): https://edk2.groups.io/g/devel/message/90309 Mute This Topic: https://groups.io/mt/91570194/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
