Hello Pranav,
Would it be possible to extend this change to the Juno aswell as the
platform has a Null Residency Counter and doesn't support OS Initiated LPI ?

Another remark is that for RdV1MC, RdN2, RdV1 and RdN2Cfg1 platforms,
CPUs don't need to be encapsulated anymore in cluster objects
Cf:
Device (CL00) {   // Cluster 0
  Name (_HID, "ACPI0010")
  Name (_UID, 0)
  ...
}
since Clusters don't have any additional information. But keeping them
is correct aswell.

Regards,
Pierre

On 6/20/22 18:53, Pranav Madhu via groups.io wrote:
Hi All,

Could you please let me know if any updates required for this series of patch?

Regards,
Pranav

*From:* Thomas Abraham <thomas.abra...@arm.com>
*Sent:* Sunday, June 12, 2022 2:16 AM
*To:* Pranav Madhu <pranav.ma...@arm.com>; devel@edk2.groups.io
*Subject:* Re: [edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low Power 
Idle states for RD platforms

On Thu, Jun 9, 2022 at 11:20 AM, Pranav Madhu wrote:

    The DSDT ACPI table used for Neoverse reference design platforms include
    the _LPI control method for the kernel to enter idle states. This patch
    series fixes bugs in the existing _LPI control method due to which
    certain high level OS failed to boot on the supported Neoverse reference
    design platforms. For each platform, the fixes include - clearing level
    ID value as the platform supports only platform co-ordinated _LPI and
    removing residency counter frequency as the platform does not implement
    residency counter.

    In addition to this, the RD-N2 and RD-N2-Cfg1 platforms are direct
    connect platforms and so the _LPI control method for cluster is removed.

    Link to github branch with the patches in this series -
    https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/lpi_fix_for_rd= 
<https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/lpi_fix_for_rd=>
    _platforms

    Pranav Madhu (7):
    Platform/Sgi: Fix ACPI Low Power Idle states for SGI575
    Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge
    Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge-X2
    Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1
    Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1-MC
    Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2
    Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2-Cfg1

    Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl | 8 +-
    Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl | 8 +-
    Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl | 78 +---------------=
    ----
    Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl | 54 +-------------
    Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl | 8 +-
    Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 8 +-
    Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 8 +-
    7 files changed, 28 insertions(+), 144 deletions(-)


For this series -
Reviewed-by: Thomas Abraham <thomas.abra...@arm.com 
<mailto:thomas.abra...@arm.com>>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90652): https://edk2.groups.io/g/devel/message/90652
Mute This Topic: https://groups.io/mt/91652410/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to