Reviewed-by: Ray Ni <ray...@intel.com> > -----Original Message----- > From: Guo, Gua <gua....@intel.com> > Sent: Monday, June 27, 2022 1:03 PM > To: Ni, Ray <ray...@intel.com>; devel@edk2.groups.io > Cc: Dong, Guo <guo.d...@intel.com>; Lu, James <james...@intel.com> > Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec > > Yes, #2 is chosen in by the python interpreter. > > -----Original Message----- > From: Guo, Gua > Sent: Monday, June 27, 2022 12:07 PM > To: Ni, Ray <ray...@intel.com>; devel@edk2.groups.io > Cc: Dong, Guo <guo.d...@intel.com>; Lu, James <james...@intel.com> > Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec > > The python logic will like for below > > > upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0 > =========> > > if BuildTarget == "DEBUG": > > upld_info_hdr.Attribute |= 1 > > else: > > upld_info_hdr.Attribute |= 0 > > Thanks, > Gua > > -----Original Message----- > From: Ni, Ray <ray...@intel.com> > Sent: Monday, June 27, 2022 11:44 AM > To: Guo, Gua <gua....@intel.com>; devel@edk2.groups.io > Cc: Dong, Guo <guo.d...@intel.com>; Lu, James <james...@intel.com> > Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec > > > + upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0 > > > I am not python expert. Above statement might be interpreted as: > 1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0 2. > upld_info_hdr.Attribute |= (1 if BuildTarget == > "DEBUG" else 0) > > Are we sure that the #2 is chosen in by the python interpreter?
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90781): https://edk2.groups.io/g/devel/message/90781 Mute This Topic: https://groups.io/mt/92013929/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
