Just following up on my outstanding edk2 patches to check on status/review 
feedback.

Thanks,
Jeff

> -----Original Message-----
> From: Jeff Brasen
> Sent: Friday, June 17, 2022 9:38 AM
> To: gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io;
> bob.c.f...@intel.com
> Cc: 'Chen, Christine' <yuwei.c...@intel.com>
> Subject: RE: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs
> 
> Anything else needed prior to getting this merged to edk2?
> 
> > -----Original Message-----
> > From: gaoliming <gaolim...@byosoft.com.cn>
> > Sent: Thursday, May 19, 2022 7:19 PM
> > To: devel@edk2.groups.io; bob.c.f...@intel.com; Jeff Brasen
> > <jbra...@nvidia.com>
> > Cc: 'Chen, Christine' <yuwei.c...@intel.com>
> > Subject: 回复: [edk2-devel] [PATCH] .gitignore: Ignore build tools build
> > logs
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
> >
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Bob Feng
> > > 发送时间: 2022年5月18日 15:15
> > > 收件人: devel@edk2.groups.io; Gao, Liming
> > <gaolim...@byosoft.com.cn>;
> > > jbra...@nvidia.com
> > > 抄送: Chen, Christine <yuwei.c...@intel.com>
> > > 主题: Re: [edk2-devel] [PATCH] .gitignore: Ignore build tools build
> > > logs
> > >
> > > They are the BaseTools build log files that are generated by
> > > BaseTools/Edk2ToolsBuild.py.
> > >
> > > Thanks,
> > > Bob
> > >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > gaoliming
> > > Sent: Wednesday, May 18, 2022 2:40 PM
> > > To: devel@edk2.groups.io; jbra...@nvidia.com
> > > Cc: Feng, Bob C <bob.c.f...@intel.com>; Chen, Christine
> > > <yuwei.c...@intel.com>
> > > Subject: 回复: [edk2-devel] [PATCH] .gitignore: Ignore build tools
> > > build logs
> > >
> > > Bob:
> > >   Do you know what files will be generated in
> > > BaseTools/BaseToolsBuild directory?
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff
> > Brasen
> > > via
> > > > groups.io
> > > > 发送时间: 2022年4月22日 1:01
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn;
> > > > yuwei.c...@intel.com; Jeff Brasen <jbra...@nvidia.com>
> > > > 主题: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs
> > > >
> > > > The python BaseTools/Edk2ToolsBuild.py creates files in
> > > > BaseTools/BaseToolsBuild and should be ignored.
> > > >
> > > > Signed-off-by: Jeff Brasen <jbra...@nvidia.com>
> > > > ---
> > > >  BaseTools/.gitignore | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore index
> > > > a45689bc89..ddf93b7116 100644
> > > > --- a/BaseTools/.gitignore
> > > > +++ b/BaseTools/.gitignore
> > > > @@ -17,4 +17,5 @@ Source/C/VfrCompile/VfrTokens.h  Source/C/bin/
> > > > Source/C/libs/
> > > >  Bin/Win32
> > > > -Lib
> > > > \ No newline at end of file
> > > > +Lib
> > > > +BaseToolsBuild/
> > > > \ No newline at end of file
> > > > --
> > > > 2.25.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > 
> > >
> >
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91159): https://edk2.groups.io/g/devel/message/91159
Mute This Topic: https://groups.io/mt/91823747/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to