-----Original Message-----
From: Thangaraj, KalaiyarasanX <kalaiyarasanx.thanga...@intel.com>
Sent: Wednesday, July 27, 2022 8:44 PM
To: devel@edk2.groups.io
Cc: Thangaraj, KalaiyarasanX <kalaiyarasanx.thanga...@intel.com>; Bi, Dandan
<dandan...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Pethaiyan,
Madhan <madhan.pethai...@intel.com>; Esakkithevar, Kathappan
<kathappan.esakkithe...@intel.com>; Balaji, Madhusudhan
<madhusudhan.bal...@intel.com>
Subject: [PATCH] VirtualKeyboardFeaturePkg: Pre OS virtual keyboard touch
response are very slow with I2C touch panel
On one Touch, multiple Reads happend and this reads varying based on Key Press
time.
Resulting in Multiple key press update on screen. This condition avoids
KeyPressed skips resulting due to faster key press and update only on valid key
press.
Cc: Dandan Bi <dandan...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Madhan Pethaiyan <madhan.pethai...@intel.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithe...@intel.com>
Cc: Madhusudhan Balaji <madhusudhan.bal...@intel.com>
Signed-off-by: KalaiyarasanX Thangaraj <kalaiyarasanx.thanga...@intel.com>
Reviewed-by: Madhusudhan Balaji <madhusudhan.bal...@intel.com>
---
Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c
| 12 ++++++++++++
Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h
| 3 +++
2 files changed, 15 insertions(+)
diff --git
a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c
b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c
index 2b1216746b..aa4bfe3baa 100644
---
a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c
+++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyb
+++ oardDxe/Keyboard.c
@@ -512,6 +512,18 @@ VkTimer (
if (!VkContext->TouchActive) {
VkContext->KeyPressed = FALSE;
}
+
+ //
+ // On one Touch, multiple Reads happend and this reads varying based on Key
Press time.
+ // Resulting in Multiple key press update on screen. This condition
+ avoids Key Press skips // resulting due to faster key press and update only
on valid key press.
+ //
+ if ((Point.CurrentX != PreviousX) || (Point.CurrentY != PreviousY)) {
+ VkContext->KeyPressed = FALSE;
+ }
+ PreviousX = Point.CurrentX;
+ PreviousY = Point.CurrentY;
+
ConvertCoordinate (VkContext, Point, &TouchX, &TouchY);
if (!VkContext->KeyPressed &&
diff --git
a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h
b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h
index 14a50fa5af..11e045f894 100644
---
a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h
+++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyb
+++ oardDxe/VirtualKeyboard.h
@@ -37,6 +37,9 @@ extern EFI_DRIVER_BINDING_PROTOCOL
gVirtualKeyboardDriverBinding;
extern EFI_COMPONENT_NAME_PROTOCOL gVirtualKeyboardComponentName;
extern EFI_COMPONENT_NAME2_PROTOCOL gVirtualKeyboardComponentName2;
+GLOBAL_REMOVE_IF_UNREFERENCED UINTN PreviousX;
+GLOBAL_REMOVE_IF_UNREFERENCED UINTN PreviousY;
+
///
/// Debug raw data points
///
--
2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91945): https://edk2.groups.io/g/devel/message/91945
Mute This Topic: https://groups.io/mt/92651285/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
