For the series: Reviewed-by: Michael Kubacki <michael.kuba...@microsoft.com>
The patch formatting seems a little strange:
1. The patches don't have "Cc" lines.
2. What is this GUID message at the bottom of each patch?
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
By the way, I tested the AARCH64 PRM build with sample modules on VS2019
a while back, so I see that you mentioned only testing GCC (thanks for
helping get the functions in the export table there) but it should work
in VS as well.
Regards,
Michael
On 8/3/2022 10:35 AM, Sami Mujawar wrote:
This patch series adds support to build PRM for AARCH64 using GCC.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2238_aarch64_prm_support_v1
Jose Marinho (5):
Basetools/GenFw: Allow AARCH64 builds to use the --prm flag
PrmPkg: Enable external visibility on PRM symbols
PrmPkg: Build Prm Samples with GCC for AARCH64
PrmPkg: Support AArch64 builds using GCC
PrmPkg: Add details on AArch64 build to the Readme.
BaseTools/Source/C/GenFw/Elf64Convert.c
| 6 ++---
PrmPkg/Include/Prm.h
| 3 +++
PrmPkg/PrmPkg.ci.yaml
| 1 +
PrmPkg/PrmPkg.dsc
| 24 +++++++++++++++++---
PrmPkg/Readme.md
| 11 +++++++++
PrmPkg/Samples/PrmSampleAcpiParameterBufferModule/PrmSampleAcpiParameterBufferModule.inf
| 4 ++++
PrmPkg/Samples/PrmSampleContextBufferModule/PrmSampleContextBufferModule.inf
| 4 ++++
7 files changed, 47 insertions(+), 6 deletions(-)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92100): https://edk2.groups.io/g/devel/message/92100
Mute This Topic: https://groups.io/mt/92793389/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
