[AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.ch...@amd.com>
> -----Original Message----- > From: Igor Kulchytskyy <ig...@ami.com> > Sent: Saturday, August 13, 2022 1:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner <abner.ch...@amd.com>; nickle.w...@hpe.com; Igor > Kulchytskyy <ig...@ami.com>; Chang, Abner <abner.ch...@amd.com> > Subject: [PATCH V3] RedfishPkg: RedfishDiscoverDxe: USB Redfish host > interface is not supported > > [CAUTION: External Email] > > Host Interface details are described by the SMBIOS Type 42 table. > The table is published by the RedfishHostInterfaceDxe driver. > That driver supports PCI-E and USB host interface types. > The table is consumed by the RedfishGetHostInterfaceProtocolData > function in the RedfishDiscoverDxe driver. > The function only supports PCI-E host interface type. > > Cc: Abner Chang <abner.ch...@amd.com> > Cc: Nickle Wang <nickle.w...@hpe.com> > Signed-off-by: Igor Kulchytskyy <ig...@ami.com> > --- > RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 10 > +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > index d79750b..0090525 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > @@ -65,10 +65,14 @@ RedfishGetHostInterfaceProtocolData ( > RecordTmp = (UINT8 *)Record + Offset; > > // > - // Check Device Type, only PCI/PCIe Network Interface v2 is supported > now. > + // Check Device Type, PCI/PCIe and USB Network Interface v2 is > supported. > // > - if (*RecordTmp == > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) { > - ASSERT (SpecificDataLen == sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + if ((*RecordTmp == > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp == > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { > + if (*RecordTmp == > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) { > + ASSERT (SpecificDataLen == sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + } else { > + ASSERT (SpecificDataLen > sizeof > (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1); > + } > *DeviceDescriptor = (REDFISH_INTERFACE_DATA *)RecordTmp; > Offset = Offset + SpecificDataLen; > RecordTmp = (UINT8 *)Record + Offset; > -- > 2.6.1.windows.1 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by > their > designee. If the reader of this message is not the intended recipient, you are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92404): https://edk2.groups.io/g/devel/message/92404 Mute This Topic: https://groups.io/mt/92984581/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-