Bob: I mean this change brings the behavior change, but this patch doesn't highlight its impact and give the suggestion to modify the impacted DSC file. Otherwise, this impact can be raised and discussed early. Now, we are near to create edk2-stable202208. There is no enough time to discuss this change. So, I suggest to revert this change for stable tag 202208.
Andrew, Lefi and Mike: The commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 (BaseTools: Fix DSC LibraryClass precedence rule) introduces this issue. This commit was merged into Edk2 on Last month (2022 July 17th). But, its impact was reported on last week. Because we are near for the stable tag edk2-stable202208, we need to make the decision to keep this change or revert this change for this stable tag. Can you give your comments on this change? Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard > Biesheuvel > 发送时间: 2022年8月24日 18:14 > 收件人: devel@edk2.groups.io; bob.c.f...@intel.com > 抄送: Gao, Liming <gaolim...@byosoft.com.cn>; rebe...@bsdio.com; Chen, > Christine <yuwei.c...@intel.com>; Andrew Fish <af...@apple.com>; Leif > Lindholm <quic_llind...@quicinc.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Wang, Jian J <jian.j.w...@intel.com> > 主题: Re: [edk2-devel] MdeModulePkg build fails for AARCH64 on Ubuntu > 22.04 > > On Wed, 24 Aug 2022 at 09:49, Ard Biesheuvel <a...@kernel.org> wrote: > > > > On Tue, 23 Aug 2022 at 09:41, Bob Feng <bob.c.f...@intel.com> wrote: > > > > > > Hi Liming, > > > > > > Reverting patch may not a good idea, some platforms have done the > implementation based on the DSC spec, if revert, those platforms build will > break. > > > > Platforms implemented against the DSC spec would have never worked if > > they relied on behavior that BaseTools currently does not implement. > > > > > This commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 make the > Basetools behavior be consistent with DSC spec so I don't think it's a > regression bug. > > > > > > > Platforms built against the current behavior that used to work might > > break after this change. MdeModulePkg.dsc for ARM/AARCH64 no longer > > builds due to this change. > > > > Also, as I pointed out, the DSC spec is far from ambiguous. > > Ugh I did it again ... > > "far from *un*ambiguous" > > Will use less difficult words from now on - I obviously cannot be > trusted with them. > > > This means > > that platforms implemented against the spec will rely on one of > > several possible interpretations of that ambiguous set of rules. > > > > So let's revert this change now. Let's fix the DSC spec next, And only > > then, let's fix the code (assuming it still needs to be fixed) > > > > -- > > Ard. > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92778): https://edk2.groups.io/g/devel/message/92778 Mute This Topic: https://groups.io/mt/93240880/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
