This sample library does not do anything. If the design is such that a NULL
library is functional, then a NULL library should be implemented. Having a
sample library that has the same function as a NULL library doesn't make sense
to me.
It looks like a NULL library would work fine in this design. If you update to
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/BaseFspWrapperPlatformMultiPhaseLibNull.inf,
that would be acceptable to me.
Regards,
Isaac
-----Original Message-----
From: Chiu, Chasel <chasel.c...@intel.com>
Sent: Wednesday, August 31, 2022 11:19 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L
<nathaniel.l.desim...@intel.com>; Oram, Isaac W <isaac.w.o...@intel.com>; Gao,
Liming <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com>
Subject: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.
FSP Wrapper has implemented FSP 2.4 MultiPhase support and required platform to
include new library instance.
Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
Cc: Isaac Oram <isaac.w.o...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Eric Dong <eric.d...@intel.com>
Signed-off-by: Chasel Chiu <chasel.c...@intel.com>
---
Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
index 8e91dba6ac..d4191c4b01 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
@@ -54,6 +54,8 @@
TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf
FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf+
FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLibSample.inf+
FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf
TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.inf
TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf
--
2.35.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93015): https://edk2.groups.io/g/devel/message/93015
Mute This Topic: https://groups.io/mt/93377589/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
