On Fri, 2 Sept 2022 at 04:12, Jianyong Wu <jianyong...@arm.com> wrote: > > Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the memory > layout for cloud hypervisor is changed, it needs a new meminfo lib. > > Signed-off-by: Jianyong Wu <jianyong...@arm.com> > > Jianyong Wu (2): > CloudHv/arm: add PeiMemInfoLib > CloudHv/arm: switch PeiMemLib to its own >
Please address the following coding style issues 2022-09-05T13:07:52.6615653Z ERROR - EFI coding style error 2022-09-05T13:07:52.6617613Z ERROR - *Error code: 4002 2022-09-05T13:07:52.6618262Z ERROR - *Function header doesn't exist 2022-09-05T13:07:52.6619906Z ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c 2022-09-05T13:07:52.6621135Z ERROR - *Line number: 25 2022-09-05T13:07:52.6622262Z ERROR - *Function [CloudHvVirtMemInfoPeiLibConstructor] has NO comment immediately preceding it. 2022-09-05T13:07:52.6623456Z ERROR - 2022-09-05T13:07:52.6624009Z ERROR - EFI coding style error 2022-09-05T13:07:52.6625006Z ERROR - *Error code: 5007 2022-09-05T13:07:52.6626154Z ERROR - *There should be no initialization of a variable as part of its declaration 2022-09-05T13:07:52.6627510Z ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c 2022-09-05T13:07:52.6628717Z ERROR - *Line number: 171 2022-09-05T13:07:52.6633439Z ERROR - *Variable Name: Index 2022-09-05T13:07:52.6634155Z ERROR - 2022-09-05T13:07:52.6634676Z ERROR - EFI coding style error 2022-09-05T13:07:52.6635217Z ERROR - *Error code: 5007 2022-09-05T13:07:52.6641270Z ERROR - *There should be no initialization of a variable as part of its declaration 2022-09-05T13:07:52.6644330Z ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c 2022-09-05T13:07:52.6645757Z ERROR - *Line number: 171 2022-09-05T13:07:52.6646858Z ERROR - *Variable Name: MemNodeIndex 2022-09-05T13:07:52.6648247Z ERROR - 2022-09-05T13:07:52.6649628Z ERROR - EFI coding style error 2022-09-05T13:07:52.6650730Z ERROR - *Error code: 8003 2022-09-05T13:07:52.6652153Z ERROR - *The #ifndef at the start of an include file should have one postfix underscore, and no prefix underscore character '_' 2022-09-05T13:07:52.6653700Z ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.h 2022-09-05T13:07:52.6655658Z ERROR - *Line number: 9 2022-09-05T13:07:52.6656423Z ERROR - *The #ifndef name [_CLOUDHV_VIRT_MEM_INFO_LIB_H_] does not follow the rules 2022-09-05T13:07:52.6658050Z ERROR - 2022-09-05T13:07:52.6658635Z ERROR - EFI coding style error 2022-09-05T13:07:52.6659800Z ERROR - *Error code: 9001 2022-09-05T13:07:52.6661130Z ERROR - *The file headers should follow Doxygen special documentation blocks in section 2.3.5 2022-09-05T13:07:52.6662905Z ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoPeiLib.inf 2022-09-05T13:07:52.6663715Z ERROR - *Line number: 1 2022-09-05T13:07:52.6666838Z ERROR - *INF/DEC/DSC/FDF file header comment should begin with "## @file" or "# @file" at the very top file -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93148): https://edk2.groups.io/g/devel/message/93148 Mute This Topic: https://groups.io/mt/93411012/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
