Hi,
On 9/30/22 13:47, Adrien Thierry wrote:
Hi Jeremy,
If you just add the range tweak, does that fix the XHCI config in your setup
too?
I tested applying the range tweak in your patch, unfortunately it doesn't
seem to work on my setup. I'm still getting "usb 1-1: device descriptor > read/64,
error -71" errors.
That is unfortunate. Which revision/how much RAM? Can you paste the
before/after kernel/pci output like:
] brcm-pcie fd500000.pcie: host bridge /scb/pcie@7d500000 ranges:
] brcm-pcie fd500000.pcie: No bus range found for /scb/pcie@7d500000,
using [bus 00-ff]
] brcm-pcie fd500000.pcie: MEM 0x0600000000..0x0603ffffff ->
0x00f8000000
] brcm-pcie fd500000.pcie: IB MEM 0x0000000000..0x00bfffffff ->
0x0000000000
] brcm-pcie fd500000.pcie: PCI host bridge to bus 0000:00
] pci_bus 0000:00: root bus resource [bus 00-ff]
] pci_bus 0000:00: root bus resource [mem 0x600000000-0x603ffffff] (bus
address [0xf8000000-0xfbffffff])
I tested it on a C0 with 8G and a B0 with 4G, and it seems to work on
both, although the C0 might have been misbehaving a bit (likely
unrelated). In both cases I swapped in the latest Pi foundation DT
(https://github.com/raspberrypi/firmware/blob/master/boot/bcm2711-rpi-4-b.dtb)
which uses the address you suggest, and it still seems to work either
way (with or without the reset). If we reroll the PFTF firmware it is
usually with the latest pi foundation DTs.
So the first patch makes sense, but I think it should probably be
checking both DT property names (pci0,0 and pci1,0) since we probably
want maximum compatibility with differing DT's the user might swap in,
and the upstream linux change which changes the node from 1,0 to 0,0 is
from august of last year, so not old at all..
The second one, I'm less sure about, since the primary thing your
changing (AFAIK) is whether the XHCI BIOS handoff is being checked, and
since EDK2 supports the hand-off and Linux doesn't throw the XHCI bios
failure message I think we actually want to leave that in place. If you
have debugging turned on, the XHCI/LegacyBios ownership control is the
message you see during exit boot services that says
"XhciClearBiosOwnership: called to clear BIOS ownership". I suspect the
kernel patch is yet another case of "UBOOT and/or the pi foundation
firmware is broken so we fixed the kernel"
Do you see a difference with/without the second patch?
Here's my SyncPcie function with the range tweak applied [1]
I'm running upstream linux 6.0-rc6 with the downstream device tree
provided in [2]
Thank you,
Adrien
[1] http://pastebin.test.redhat.com/1075875
[2] https://github.com/pftf/RPi4/releases/tag/v1.33
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94688): https://edk2.groups.io/g/devel/message/94688
Mute This Topic: https://groups.io/mt/94002759/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
