Hi Michael, Please see feedback inline.
Thanks, Nate > -----Original Message----- > From: mikub...@linux.microsoft.com <mikub...@linux.microsoft.com> > Sent: Tuesday, October 4, 2022 9:07 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Desimone, > Nathaniel L <nathaniel.l.desim...@intel.com>; Luo, Heng > <heng....@intel.com> > Subject: [edk2-platforms][PATCH v1 3/3] TigerlakeSiliconPkg: Fix invalid > debug macros > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4095 > > Updates several debug macros in TigerlakeSiliconPkg to correctly match print > specifiers to actual arguments. > > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Heng Luo <heng....@intel.com> > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > --- > > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c > | 2 +- > > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c > | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c > > b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c > index 791747440662..01c097723083 100644 > --- > a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c > +++ > b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c > @@ -323,7 +323,7 @@ GbeMdiGetLanPhyRevision ( > Status = EFI_DEVICE_ERROR; > goto phy_exit; > } > - DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. > Overriding LANPHYPC\n", Status)); > + DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. > Overriding LANPHYPC.\n"));; That does not seem to be what the original author intended. I suspect this is the intent: DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. Overriding LANPHYPC. Status: %r\n", Status)); > // > // Taking over LANPHYPC > // 1. SW signal override - 1st cycle. > diff --git > a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c > > b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c > index 401a9fbe7b8a..d1c163c50f63 100644 > --- > a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c > +++ > b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c > @@ -1227,7 +1227,7 @@ RecursiveIoApicCheck ( > IoApicPresent = FALSE; > > if (IsIoApicDevice (SbdfToBase (Sbdf))) { > - DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, > Sbdf.Func)); > + DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, > Sbdf.Func)); That does not seem to be what the original author intended. I suspect this is the intent: DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Seg, Sbdf.Bus, Sbdf.Dev, Sbdf.Func)); > return TRUE; > } > if (HasChildBus (Sbdf, &ChildSbdf)) { > -- > 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95023): https://edk2.groups.io/g/devel/message/95023 Mute This Topic: https://groups.io/mt/94129547/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
