Reviewed-by: Nate DeSimone <nathaniel.l.desim...@intel.com> > -----Original Message----- > From: Chiu, Chasel <chasel.c...@intel.com> > Sent: Thursday, October 27, 2022 7:58 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4126 > > Common functions will have either 32bit or 64bit instances which having > different return code size. Function header should support both scenarios. > > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Star Zeng <star.z...@intel.com> > Signed-off-by: Chasel Chiu <chasel.c...@intel.com> > --- > IntelFsp2Pkg/FspSecCore/SecFsp.h | 4 ++-- > IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h | 12 ++++++------ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/IntelFsp2Pkg/FspSecCore/SecFsp.h > b/IntelFsp2Pkg/FspSecCore/SecFsp.h > index e84528b378..d7a5976c12 100644 > --- a/IntelFsp2Pkg/FspSecCore/SecFsp.h > +++ b/IntelFsp2Pkg/FspSecCore/SecFsp.h > @@ -70,7 +70,7 @@ FspDataPointerFixUp ( > @return FSP binary base address. > > **/ > -UINT32 > +UINTN > EFIAPI > AsmGetFspBaseAddress ( > VOID > @@ -82,7 +82,7 @@ AsmGetFspBaseAddress ( > @return FSP binary base address. > > **/ > -UINT32 > +UINTN > EFIAPI > AsmGetFspInfoHeader ( > VOID > diff --git a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > index c91ea4a78f..598fdb9ec5 100644 > --- a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > +++ b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > @@ -17,10 +17,10 @@ > The callee should not use XMM6/XMM7. > The return address is saved in MM7. > > - @retval in saved in EAX - 0 means platform initialization success. > + @retval in saved in EAX/RAX - 0 means platform initialization success. > other means platform initialization fail. > **/ > -UINT32 > +UINTN > EFIAPI > SecPlatformInit ( > VOID > @@ -37,10 +37,10 @@ SecPlatformInit ( > > @param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data > structure. It is saved in ESP. > > - @retval in saved in EAX - 0 means Microcode is loaded successfully. > + @retval in saved in EAX/RAX - 0 means Microcode is loaded successfully. > other means Microcode is not loaded successfully. > **/ > -UINT32 > +UINTN > EFIAPI > LoadMicrocode ( > IN VOID *FsptUpdDataPtr > @@ -56,10 +56,10 @@ LoadMicrocode ( > > @param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data > structure. It is saved in ESP. > > - @retval in saved in EAX - 0 means CAR initialization success. > + @retval in saved in EAX/RAX - 0 means CAR initialization success. > other means CAR initialization fail. > **/ > -UINT32 > +UINTN > EFIAPI > SecCarInit ( > IN VOID *FsptUpdDataPtr > -- > 2.35.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95785): https://edk2.groups.io/g/devel/message/95785 Mute This Topic: https://groups.io/mt/94619463/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
