Still need reviews (thanks Liming). Please help review your package.
Thanks,
Michael
On 11/15/2022 10:00 AM, Michael Kubacki wrote:
Maintainers/reviewers,
This is an important series for us to make progress on enabling CodeQL
and needs cooperation from maintainers across several packages.
I have not received any feedback yet.
Most of these patches should not take long to review. Please help review
your patches so we can continue forward momentum on enabling code
scanning in the repo.
Thanks,
Michael
On 11/9/2022 12:32 PM, Michael Kubacki wrote:
From: Michael Kubacki <[email protected]>
Adds queries for the following:
1. cpp/conditionallyuninitializedvariable
2. cpp/pointer-overflow-check
3. cpp/overrunning-write
4. cpp/overrunning-write-with-float
5. cpp/very-likely-overrunning-write
These check for vulnerabilities with the following CWEs:
- https://cwe.mitre.org/data/definitions/120.html
- https://cwe.mitre.org/data/definitions/457.html
- https://cwe.mitre.org/data/definitions/676.html
- https://cwe.mitre.org/data/definitions/758.html
- https://cwe.mitre.org/data/definitions/787.html
- https://cwe.mitre.org/data/definitions/805.html
The first part of this patch series contains fixes for CodeQL alerts
across various packages that are produced by the new queries being
enabled.
The second part updates the CodeQL queries.
Cc: Bob Feng <[email protected]>
Cc: Dandan Bi <[email protected]>
Cc: Eric Dong <[email protected]>
Cc: Erich McMillan <[email protected]>
Cc: Guomin Jiang <[email protected]>
Cc: Jian J Wang <[email protected]>
Cc: Jiaxin Wu <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Maciej Rabeda <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Michael Kubacki <[email protected]>
Cc: Rahul Kumar <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Sean Brogan <[email protected]>
Cc: Siyuan Fu <[email protected]>
Cc: Star Zeng <[email protected]>
Cc: Xiaoyu Lu <[email protected]>
Cc: Yuwei Chen <[email protected]>
Cc: Zhichao Gao <[email protected]>
Cc: Zhiguang Liu <[email protected]>
Signed-off-by: Michael Kubacki <[email protected]>
Erich McMillan (1):
MdeModulePkg/SmbiosDxe: Fix pointer and buffer overflow CodeQL alerts
Michael Kubacki (11):
BaseTools/PatchCheck.py: Add PCCTS to tab exemption list
BaseTools/VfrCompile: Fix potential buffer overwrites
CryptoPkg: Fix conditionally uninitialized variable
MdeModulePkg: Fix conditionally uninitialized variables
MdePkg: Fix conditionally uninitialized variables
NetworkPkg: Fix conditionally uninitialized variables
PcAtChipsetPkg: Fix conditionally uninitialized variables
ShellPkg: Fix conditionally uninitialized variables
UefiCpuPkg: Fix conditionally uninitialized variables
.github/codeql/edk2.qls: Enable CWE 457, 676, and 758 queries
.github/codeql/edk2.qls: Enable CWE 120, 787, and 805 queries
BaseTools/Source/C/VfrCompile/Pccts/antlr/gen.c | 10 ++--
BaseTools/Source/C/VfrCompile/Pccts/antlr/main.c | 4 +-
CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 21
++++----
MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 5 +-
MdeModulePkg/Bus/Pci/UhciDxe/Uhci.c | 24
+++++----
MdeModulePkg/Core/Dxe/Mem/Page.c | 17
+++---
MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c | 25
+++++----
MdeModulePkg/Library/FileExplorerLib/FileExplorer.c | 5 +-
MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 33
++++++------
MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c | 11 ++--
MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 14
+++--
MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 4 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +-
MdePkg/Library/BaseLib/String.c | 20
++++---
NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c | 2 +-
NetworkPkg/TcpDxe/TcpInput.c | 3 ++
PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 9 ++--
ShellPkg/Application/Shell/Shell.c | 2 +-
ShellPkg/Application/Shell/ShellProtocol.c | 4 +-
ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 56
+++++++++++---------
ShellPkg/Library/UefiShellDebug1CommandsLib/Dblk.c | 18
++++---
ShellPkg/Library/UefiShellDebug1CommandsLib/EfiDecompress.c | 9 ++--
ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c | 14
++---
ShellPkg/Library/UefiShellDriver1CommandsLib/Disconnect.c | 17
+++---
ShellPkg/Library/UefiShellDriver1CommandsLib/DrvDiag.c | 21
++++----
UefiCpuPkg/CpuMpPei/CpuBist.c | 8 ++-
UefiCpuPkg/CpuMpPei/CpuMpPei.c | 8 ++-
UefiCpuPkg/CpuMpPei/CpuPaging.c | 9 +++-
.github/codeql/edk2.qls | 10 ++++
BaseTools/Scripts/PatchCheck.py | 4 +-
MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf | 1 +
31 files changed, 238 insertions(+), 152 deletions(-)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96590): https://edk2.groups.io/g/devel/message/96590
Mute This Topic: https://groups.io/mt/94918084/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
