Hi Rebecca,
Thanks for your response. I will fixed it next.
Thanks,
Richard
-----Original Message-----
From: Rebecca Cran <rebe...@quicinc.com>
Sent: 2022年12月1日 11:47 PM
To: devel@edk2.groups.io; Richard Ho (何明忠) <richar...@ami.com>
Cc: Andrew Fish <af...@apple.com>; Leif Lindholm <quic_llind...@quicinc.com>;
Michael D Kinney <michael.d.kin...@intel.com>; Michael Kubacki
<michael.kuba...@microsoft.com>; Zhiguang Liu <zhiguang....@intel.com>; Liming
Gao <gaolim...@byosoft.com.cn>; Tony Lo (羅金松) <ton...@ami.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add
USB RNDIS devices support
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening attachments, clicking links, or following guidance.**
On 10/3/22 03:26, RichardHo [何明忠] via groups.io wrote:
> diff --git a/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c
> b/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c
> new file mode 100644
> index 0000000000..5db95b284c
> --- /dev/null
> +++ b/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c
> +/**
> + This function is called when UndiShutdown is invoked.
> +
> + @param[in] Cdb A pointer to the command descriptor block.
> + @param[in] Nic A pointer to the Network interface controller data.
> +
> + @retval EFI_SUCCESS The request executed successfully.
> +
> +**/
> +EFI_STATUS
> +EFIAPI
> +RndisUndiShutdown (
> + IN PXE_CDB *Cdb,
> + IN NIC_DATA *Nic
> + )
> +{
> + EDKII_USB_ETHERNET_PROTOCOL *UsbEthDriver = Nic->UsbEth;
> + USB_RNDIS_DEVICE *UsbRndisDevice = USB_RNDIS_DEVICE_FROM_THIS
> (UsbEthDriver);
> + REMOTE_NDIS_HALT_MSG RndisHltMsg;
> + EFI_STATUS Status;
> +
> + DEBUG ((DEBUG_INFO, "RndisUndiShutdown\n"));
According to the edk2 coding style, you should declare and initialize variables
separately.
+/**
+ This is a dummy function which just returns. Unimplimented
EDKII_USB_ETHERNET_PROTOCOL functions
+ point to this function.
Typo. Should be "Unimplemented".
diff --git a/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h
b/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h
index 98eef820d895..9d607da72051 100644
--- a/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h
+++ b/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h
+#define USB_ETH_FRAME_SIZE 0x5F2 // frome network stack
Typo.
--
Rebecca Cran
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96890): https://edk2.groups.io/g/devel/message/96890
Mute This Topic: https://groups.io/mt/94086820/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
