On Mon, Dec 19, 2022 at 04:36:20PM +0000, Anthony PERARD via groups.io wrote:
> From: Anthony PERARD <anthony.per...@citrix.com>
> 
> Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei.
> 
> QemuFwCfgLib expect this HOB to be present, or fails to do anything.
> InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not
> check if the HOB is actually present for example and try to use a NULL
> pointer.
> 
> Fixes: cda98df16228 ("OvmfPkg/QemuFwCfgLib: remove mQemuFwCfgSupported + 
> mQemuFwCfgDmaSupported")
> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>

Reviewed-by: Gerd Hoffmann <kra...@redhat.com>

You might also consider moving global variables to the PlatformInfoHob
or use PlatformInitLib functions instead of your own copy or both.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97616): https://edk2.groups.io/g/devel/message/97616
Mute This Topic: https://groups.io/mt/95768201/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to