OK. I see. I am fine with that. Reviewed-by: Ray Ni <ray...@intel.com>
> -----Original Message----- > From: Guo, Gua <gua....@intel.com> > Sent: Tuesday, December 20, 2022 9:33 AM > To: Ni, Ray <ray...@intel.com>; Liu, KasimX <kasimx....@intel.com>; > devel@edk2.groups.io > Cc: Dong, Guo <guo.d...@intel.com>; Lu, James <james...@intel.com> > Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > The goal reduce macro requirement to build UniversalPayloadBuild.py. > > For UPL: UefiPayloadPkg dynamic to set PCD based on UPL defined HOB. > > For PPL: These PCDs on PPL (Booloader) will keep on FixedAtBuild and generate > HOB data. > > So the change is move these PCD have compatibility FixedAtBuild only to > FixedAtBuild + Dynamic. > > Thanks, > Gua Guo > > -----Original Message----- > From: Ni, Ray <ray...@intel.com> > Sent: Monday, December 19, 2022 3:43 PM > To: Liu, KasimX <kasimx....@intel.com>; devel@edk2.groups.io > Cc: Dong, Guo <guo.d...@intel.com>; Lu, James <james...@intel.com>; Guo, Gua > <gua....@intel.com> > Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > The initial goal was to remove dynamic PCD dependency from bootloader. > Is that still the goal? > If yes, maybe depending on dynamic PCD is not a good idea. > > Thanks, > Ray > > > -----Original Message----- > > From: Liu, KasimX <kasimx....@intel.com> > > Sent: Monday, December 19, 2022 3:40 PM > > To: devel@edk2.groups.io > > Cc: Liu, KasimX <kasimx....@intel.com>; Dong, Guo > > <guo.d...@intel.com>; Ni, Ray <ray...@intel.com>; Lu, James > > <james...@intel.com>; Guo, Gua <gua....@intel.com> > > Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > > > From: KasimX Liu <kasimx....@intel.com> > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 > > > > In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro > > list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to > > PcdsDynamicEx > > > > Cc: Guo Dong <guo.d...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: James Lu <james...@intel.com> > > Cc: Gua Guo <gua....@intel.com> > > Signed-off-by: KasimX Liu <kasimx....@intel.com> > > --- > > PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > index ed2d95550b..a53ca777e8 100644 > > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > @@ -84,6 +84,14 @@ > > # @Prompt RTC Target Register address > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x0000 > > 0023 > > > > > > > > + ## Specifies RTC Index Register address in I/O space. > > > > + # @Prompt RTC Index Register address > > > > + > > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x00000 > > + 01E > > > > + > > > > + ## Specifies RTC Target Register address in I/O space. > > > > + # @Prompt RTC Target Register address > > > > + > > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000 > > + 001F > > > > + > > > > [PcdsFixedAtBuild, PcdsPatchableInModule] > > > > ## Defines the ACPI register set base address. > > > > # The invalid 0xFFFF is as its default value. It must be configured to > > the real value. > > > > @@ -146,14 +154,6 @@ > > # @Prompt Initial value for Register_D in RTC. > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0 > > x0000001D > > > > > > > > - ## Specifies RTC Index Register address in I/O space. > > > > - # @Prompt RTC Index Register address > > > > - > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001 > > E > > > > - > > > > - ## Specifies RTC Target Register address in I/O space. > > > > - # @Prompt RTC Target Register address > > > > - > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x000000 > > 1F > > > > - > > > > ## RTC Update Timeout Value(microsecond). > > > > # @Prompt RTC Update Timeout Value. > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UIN > > T32|0x00000020 > > > > -- > > 2.32.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97625): https://edk2.groups.io/g/devel/message/97625 Mute This Topic: https://groups.io/mt/95760949/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
