Gerd: I will merge these two changes in tools_def.txt. Is it OK to you? Thanks Liming > -----邮件原件----- > 发件人: [email protected] <[email protected]> 代表 gaoliming via > groups.io > 发送时间: 2022年12月7日 9:36 > 收件人: [email protected]; [email protected]; [email protected] > 抄送: 'Alexey Kardashevskiy' <[email protected]>; 'Erdem Aktas' > <[email protected]>; 'Pawel Polawski' <[email protected]>; > 'Jordan Justen' <[email protected]>; 'Ard Biesheuvel' > <[email protected]>; 'Yuwei Chen' <[email protected]>; 'Tom > Lendacky' <[email protected]>; 'James Bottomley' > <[email protected]>; 'Oliver Steffen' <[email protected]>; 'Jiewen Yao' > <[email protected]>; 'Min Xu' <[email protected]>; 'Brijesh Singh' > <[email protected]>; 'Bob Feng' <[email protected]> > 主题: 回复: [edk2-devel] [PATCH v7 2/2] tools_def: add > -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS > > Gerd: > I have no comments for this change. Acked-by: Liming Gao > <[email protected]> > > Thanks > Liming > > -----邮件原件----- > > 发件人: [email protected] <[email protected]> 代表 Brian J. > > Johnson > > 发送时间: 2022年12月2日 0:18 > > 收件人: [email protected]; [email protected] > > 抄送: Alexey Kardashevskiy <[email protected]>; Liming Gao > > <[email protected]>; Erdem Aktas <[email protected]>; > > Pawel Polawski <[email protected]>; Jordan Justen > > <[email protected]>; Ard Biesheuvel <[email protected]>; > > Yuwei Chen <[email protected]>; Tom Lendacky > > <[email protected]>; James Bottomley <[email protected]>; > > Oliver Steffen <[email protected]>; Jiewen Yao > <[email protected]>; > > Min Xu <[email protected]>; Brijesh Singh <[email protected]>; > Bob > > Feng <[email protected]> > > 主题: Re: [edk2-devel] [PATCH v7 2/2] tools_def: add > > -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS > > > > OK. Doesn't look like a big impact. > > > > Thanks, > > Brian J. Johnson > > -------- Original Message -------- > > From: Gerd Hoffmann [mailto:[email protected]] > > Sent: Thursday, December 1, 2022 at 2:38 AM > > To: Brian J. Johnson <[email protected]> > > Cc: [email protected], Alexey Kardashevskiy <[email protected]>, Liming > > Gao <[email protected]>, Erdem Aktas > <[email protected]>, > > Pawel Polawski <[email protected]>, Jordan Justen > > <[email protected]>, Ard Biesheuvel <[email protected]>, > > Yuwei Chen <[email protected]>, Tom Lendacky > > <[email protected]>, James Bottomley <[email protected]>, > > Oliver > > Steffen <[email protected]>, Jiewen Yao <[email protected]>, Min > Xu > > <[email protected]>, Brijesh Singh <[email protected]>, Bob Feng > > <[email protected]> > > Subject: [edk2-devel] [PATCH v7 2/2] tools_def: add > > -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS > > > > On Wed, Nov 30, 2022 at 01:28:42PM -0600, Brian J. Johnson wrote: > > > Gerd, > > > > > > Sorry, gotta ask: does this make much difference in the size of the > > > compiled code? That's a constraint on many real-hardware X64 > platforms, > > > especially for 32-bit code. > > > > Quick test with OvmfPkg/OvmfPkgIa32X64.dsc (sec/pei ia32, dxe x64): > > > > master branch: > > > > FV Space Information > > SECFV [11%Full] 212992 (0x34000) total, 23728 (0x5cb0) used, 189264 > > (0x2e350) free > > PEIFV [34%Full] 917504 (0xe0000) total, 319416 (0x4dfb8) used, 598088 > > (0x92048) free > > DXEFV [49%Full] 12582912 (0xc00000) total, 6268032 (0x5fa480) used, > > 6314880 (0x605b80) free > > FVMAIN_COMPACT [98%Full] 1753088 (0x1ac000) total, 1725328 > (0x1a5390) > > used, 27760 (0x6c70) free > > > > with patch applied: > > > > FV Space Information > > SECFV [11%Full] 212992 (0x34000) total, 23728 (0x5cb0) used, 189264 > > (0x2e350) free > > PEIFV [34%Full] 917504 (0xe0000) total, 319416 (0x4dfb8) used, 598088 > > (0x92048) free > > DXEFV [50%Full] 12582912 (0xc00000) total, 6335936 (0x60adc0) used, > > 6246976 (0x5f5240) free > > FVMAIN_COMPACT [99%Full] 1753088 (0x1ac000) total, 1738176 > (0x1a85c0) > > used, 14912 (0x3a40) free > > > > So slightly more for 64-bit code. > > > > take care, > > Gerd > > > > > > > > > > > > > > > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97645): https://edk2.groups.io/g/devel/message/97645 Mute This Topic: https://groups.io/mt/95798708/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
