Okay, a bit more testing - it seems all debug builds hang at that point. I tested back to edk2-stable202111 so I think that's a coreboot problem.
Your patch does resolve release builds not booting. > Could you help to use latest Edk2 repo UPL to reproduce the issue that @Sean Rhodes <sean@starlabs.systems> encounter from Coreboot + ShimLayer + UPL ? I'm only testing non-universal payload - the shimlayer doesn't work as no-one could figure out how to make `ElfCt->FileSize` the right size. On Thu, 22 Dec 2022 at 02:49, Lu, James <james...@intel.com> wrote: > Reviewed-by: James Lu <james...@intel.com> > > -----Original Message----- > From: Dong, Guo <guo.d...@intel.com> > Sent: Thursday, December 22, 2022 5:25 AM > To: devel@edk2.groups.io > Cc: Dong, Guo <guo.d...@intel.com>; Ni, Ray <ray...@intel.com>; Rhodes, > Sean <sean@starlabs.systems>; Lu, James <james...@intel.com>; Guo, Gua < > gua....@intel.com> > Subject: [edk2-devel][PATCH] UefiPayloadPkg: Fix boot issue for > non-universal payload > > From: Guo Dong <guo.d...@intel.com> > > BDS module was moved from DXEFV to newly created BDSFV recently. > Non-universal UEFI payload doesn't support multiple FV, so it failed to > boot since BDS module could not be found. > This patch add BDS back to DXEFV when UNIVERSAL_PAYLOAD is not set. > > Cc: Ray Ni <ray...@intel.com> > Cc: Sean Rhodes <sean@starlabs.systems> > Cc: James Lu <james...@intel.com> > Cc: Gua Guo <gua....@intel.com> > Signed-off-by: Guo Dong <guo.d...@intel.com> > --- > UefiPayloadPkg/UefiPayloadPkg.fdf | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index 94ba922244..ee7d718b3f 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -59,9 +59,6 @@ INF UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf > FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-E77F1DB2D793 { SECTION > FV_IMAGE = DXEFV }-FILE FV_IMAGE = FBE6C1E3-2F80-4770-88B0-494186E3346F {- > SECTION FV_IMAGE = BDSFV-} > ################################################################################ > [FV.BDSFV]@@ -277,6 +274,10 @@ INF > MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf > INF > MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > !endif +!if $(UNIVERSAL_PAYLOAD) == FALSE+INF > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf+!endif+ # # UEFI network modules > #-- > 2.35.1.windows.2 > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97717): https://edk2.groups.io/g/devel/message/97717 Mute This Topic: https://groups.io/mt/95815569/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-