[AMD Official Use Only - General] Thanks Isaac, V2 was sent to address your comments on patch 1/3 and 2/3.
Abner > -----Original Message----- > From: Oram, Isaac W <isaac.w.o...@intel.com> > Sent: Thursday, January 5, 2023 8:10 AM > To: devel@edk2.groups.io; Chang, Abner <abner.ch...@amd.com> > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Nickle Wang <nick...@nvidia.com>; Igor > Kulchytskyy <ig...@ami.com> > Subject: RE: [edk2-devel] [edk2-platforms][PATCH 1/3] > Features/IpmiFeaturePkg: Add IPMI functions > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Abner, > > The @param and IN, OUT tagging on the parameters do not match for > IpmiGetChannelInfo and IpmiGetLanConfigurationParameters functions. > Please align and comment the expected usage and input handling that the > API implementation is expected to provide. > > Regards, > Isaac > > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, > Abner via groups.io > Sent: Friday, December 23, 2022 5:27 AM > To: devel@edk2.groups.io > Cc: Oram, Isaac W <isaac.w.o...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Nickle Wang <nick...@nvidia.com>; Igor > Kulchytskyy <ig...@ami.com> > Subject: [edk2-devel] [edk2-platforms][PATCH 1/3] > Features/IpmiFeaturePkg: Add IPMI functions > > From: Abner Chang <abner.ch...@amd.com> > > Add functions to get system UUID and LAN configuration parameter. > > Signed-off-by: Abner Chang <abner.ch...@amd.com> > Cc: Isaac Oram <isaac.w.o...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Nickle Wang <nick...@nvidia.com> > Cc: Igor Kulchytskyy <ig...@ami.com> > --- > .../Include/Library/IpmiCommandLib.h | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/I > pmiCommandLib.h > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/ > IpmiCommandLib.h > index 18f9d123c9..c816750544 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/I > pmiCommandLib.h > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/ > +++ IpmiCommandLib.h > @@ -2,6 +2,8 @@ > This library abstract how to send/receive IPMI command. > > Copyright (c) 2018-2021, Intel Corporation. All rights reserved.<BR> > +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights > +reserved.<BR> > + > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -88,6 +90,43 @@ IpmiSendMessage ( > IN OUT UINT32 *SendMessageResponseSize > ); > > +/** > + This function gets the system UUID. > + > + @param[out] SystemGuid The pointer to retrieve system UUID. > + > + @retval EFI_SUCCESS UUID is returned. > + @retval EFI_INVALID_PARAMETER SystemGuid is a NULL pointer. > + @retval Others Other errors. > + > +**/ > +EFI_STATUS > +EFIAPI > +IpmiGetSystemUuid ( > + OUT EFI_GUID *SystemGuid > + ); > + > +/** > + This function gets the channel information. > + > + @param[in] GetChannelInfoRequest The get channel information > request. > + @param[in] GetChannelInfoResponse The get channel information > response. > + @param[in,out] GetChannelInfoResponseSize When input, the expected > size of response. > + When output, the exact size of > the returned > + response. > + > + @retval EFI_SUCCESS Get channel information successfully. > + @retval Others Other errors. > + > +**/ > +EFI_STATUS > +EFIAPI > +IpmiGetChannelInfo ( > + IN IPMI_GET_CHANNEL_INFO_REQUEST *GetChannelInfoRequest, > + OUT IPMI_GET_CHANNEL_INFO_RESPONSE *GetChannelInfoResponse, > + OUT UINT32 *GetChannelInfoResponseSize > + ); > + > // > // NetFnTransport > // > @@ -114,6 +153,27 @@ IpmiGetSolConfigurationParameters ( > IN OUT UINT32 > *GetConfigurationParametersResponseSize > ); > > +/** > + This function gets the LAN configuration parameter. > + > + @param[in] GetLanConfigurationParametersRequest Request data > + @param[in] GetLanConfigurationParametersResponse Response data > + @param[in,out] GetLanConfigurationParametersSize When input, the > expected size of response data. > + When out, the exact > size of response data. > + > + @retval EFI_SUCCESS Lan configuration parameter is returned in the > response. > + @retval Others Other errors. > + > +**/ > + > +EFI_STATUS > +EFIAPI > +IpmiGetLanConfigurationParameters ( > + IN IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST > *GetLanConfigurationParametersRequest, > + OUT IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE > *GetLanConfigurationParametersResponse, > + IN OUT UINT32 > *GetLanConfigurationParametersSize > + ); > + > // > // NetFnChasis > // > -- > 2.37.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98015): https://edk2.groups.io/g/devel/message/98015 Mute This Topic: https://groups.io/mt/95844504/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
