Konstantin, The patch missed "Signed-off-by:", I help you add it and open a PR https://github.com/tianocore/edk2/pull/3909 for merge.
Thanks, Bob From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng Sent: Tuesday, January 17, 2023 1:05 PM To: Jake Garver <j...@nvidia.com>; Konstantin Aladyshev <aladyshe...@gmail.com>; devel@edk2.groups.io Cc: Gao, Liming <gaolim...@byosoft.com.cn>; Chen, Christine <yuwei.c...@intel.com> Subject: Re: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionROM build Reviewed-by: Bob Feng <bob.c.f...@intel.com<mailto:bob.c.f...@intel.com>> From: Jake Garver <j...@nvidia.com<mailto:j...@nvidia.com>> Sent: Wednesday, December 14, 2022 2:48 AM To: Konstantin Aladyshev <aladyshe...@gmail.com<mailto:aladyshe...@gmail.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Feng, Bob C <bob.c.f...@intel.com<mailto:bob.c.f...@intel.com>>; Gao, Liming <gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn>>; Chen, Christine <yuwei.c...@intel.com<mailto:yuwei.c...@intel.com>> Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build Thanks, Konstantin, I approve this version. Thanks, Jake ________________________________ From: Konstantin Aladyshev <aladyshe...@gmail.com<mailto:aladyshe...@gmail.com>> Sent: Tuesday, December 13, 2022 11:22 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Cc: bob.c.f...@intel.com<mailto:bob.c.f...@intel.com> <bob.c.f...@intel.com<mailto:bob.c.f...@intel.com>>; gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn> <gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn>>; yuwei.c...@intel.com<mailto:yuwei.c...@intel.com> <yuwei.c...@intel.com<mailto:yuwei.c...@intel.com>>; Jake Garver <j...@nvidia.com<mailto:j...@nvidia.com>>; Konstantin Aladyshev <aladyshe...@gmail.com<mailto:aladyshe...@gmail.com>> Subject: [PATCH] Fix cyclic dependency error on OptionROM build External email: Use caution opening links or attachments EDKII build system supports OptionROM generation if particular PCI_* defines are present in the module INF file: ``` [Defines] ... PCI_VENDOR_ID = <...> PCI_DEVICE_ID = <...> PCI_CLASS_CODE = <...> PCI_REVISION = <...> ``` Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 ("BaseTools/Conf: Fix Dynamic-Library-File template") it is no longer possible. The build system fails with the error: ``` Cyclic dependency detected while generating rule for "<...>/DEBUG/<...>.efi" file ``` Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output files to fix the cyclic dependency. --- BaseTools/Conf/build_rule.template | 1 - 1 file changed, 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template index af4819de92..21ccd864fa 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -342,7 +342,6 @@ <OutputFile> $(OUTPUT_DIR)(+)$(MODULE_NAME).efi - $(DEBUG_DIR)(+)$(MODULE_NAME).efi $(OUTPUT_DIR)(+)$(MODULE_NAME).map <Command.MSFT, Command.INTEL, Command.CLANGPDB> -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98639): https://edk2.groups.io/g/devel/message/98639 Mute This Topic: https://groups.io/mt/95647902/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
