Thanks Ard. Tommy, I will wait for Patch V2 with the correct INF_VERSION.
Thanks, Isaac -----Original Message----- From: Ard Biesheuvel <a...@kernel.org> Sent: Tuesday, January 17, 2023 3:16 PM To: devel@edk2.groups.io; Oram, Isaac W <isaac.w.o...@intel.com> Cc: Tommy Huang <tommy_hu...@aspeedtech.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; quic_llind...@quicinc.com; Kinney, Michael D <michael.d.kin...@intel.com>; Chen, Ryan <ryan_c...@aspeedtech.com>; bmc...@aspeedtech.com Subject: Re: [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver Note that the value in the INF_VERSION field cannot be chosen arbitrarily - it should be the latest version of the INF spec, so 1.29 (you don't need to put a hex value here, just "1.29" is fine) On Tue, 17 Jan 2023 at 23:40, Isaac Oram <isaac.w.o...@intel.com> wrote: > > Reviewed-by: Isaac Oram <isaac.w.o...@intel.com> > > Note that you do not need a cover letter for single commit reviews. It is > needed for multi-commit reviews so that you can describe the whole patch > series. > > -----Original Message----- > From: Tommy Huang <tommy_hu...@aspeedtech.com> > Sent: Tuesday, January 10, 2023 10:08 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Oram, > Isaac W <isaac.w.o...@intel.com>; quic_llind...@quicinc.com; Kinney, > Michael D <michael.d.kin...@intel.com>; Chen, Ryan > <ryan_c...@aspeedtech.com>; bmc...@aspeedtech.com > Subject: [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: > Update X64/AArch Gop UEFI Driver > > 1. Add ASpeedAst2600GopDxe.inf. > 2. Add ASpeedAst2600Gop file for AArch64. > 3. Update the others Gop UEFI binaries into the recently version. The version > will be v1.13.02. > > Cc: Isaac Oram <isaac.w.o...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Leif Lindholm <quic_llind...@quicinc.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Ryan Chen <ryan_c...@aspeedtech.com> > Cc: BMC-SW <bmc...@aspeedtech.com> > > Signed-off-by: Tommy Huang <tommy_hu...@aspeedtech.com> > --- > .../AArch64/ASpeedAst2500Gop.efi | Bin 42880 -> 45056 bytes > .../AArch64/ASpeedAst2600Gop.efi | Bin 0 -> 45056 bytes > .../ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++-- > .../ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 22 ++++++++++++++++++ > .../ASpeedGopBinPkg/X64/ASpeedAst2500Gop.efi | Bin 36928 -> 33600 > bytes .../ASpeedGopBinPkg/X64/ASpeedAst2600Gop.efi | Bin 32544 -> > 29952 bytes > 6 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 > Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2600Gop.efi > create mode 100644 > Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98740): https://edk2.groups.io/g/devel/message/98740 Mute This Topic: https://groups.io/mt/96211670/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
