Reviewed-by: Jiewen Yao <jiewen....@intel.com> Merged https://github.com/tianocore/edk2/pull/3918
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd > Hoffmann > Sent: Tuesday, January 17, 2023 7:33 PM > To: Xu, Min M <min.m...@intel.com> > Cc: devel@edk2.groups.io; Aktas, Erdem <erdemak...@google.com>; James > Bottomley <j...@linux.ibm.com>; Yao, Jiewen <jiewen....@intel.com>; Tom > Lendacky <thomas.lenda...@amd.com>; Afranji, Ryan <afra...@google.com> > Subject: Re: [edk2-devel] [PATCH V3 0/2] [PATCH V1 0/2] Refactor TDX > MmioExit > > On Tue, Jan 17, 2023 at 03:43:28PM +0800, Min Xu wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4169 > > > > The previous TDX MmioExit doesn't handle the Mmio instructions correctly > > in some scenarios. This patch-set refactors the implementation to fix the > > issues. > > > > Before the refactoring, common X86 instruction codes in CcExitVcHandler.c > > are moved to separate files (CcInstruction.h / CcInstruction.c) so that > > these codes can be re-used in TDX. > > > > Code: https://github.com/mxu9/edk2/tree/TdxMmioExit.v3 > > > > v3 changes: > > - Handle the error if an error is returned from TdxMmioReadWrite. > > - Add more check in ParseMmioExitInstructions. > > > > v2 changes: > > - Add CpuDeadLoop () after each TDVMCALL(HALT) in VE handler. Because > > TDVMCALL(HALT) is not trusted. > > - Other minor changes such as deleting ASSERT in VE handler. Because > > any error in VE handler will trigger CpuDeadLoop (). So ASSERT is not > > needed any more. > > Series: > Acked-by: Gerd Hoffmann <kra...@redhat.com> > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98759): https://edk2.groups.io/g/devel/message/98759 Mute This Topic: https://groups.io/mt/96325923/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
