Merged https://github.com/tianocore/edk2/pull/3920

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> Sent: Wednesday, January 18, 2023 8:15 AM
> To: Xu, Min M <min.m...@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.w...@intel.com>
> Subject: Re: [edk2-devel] [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI
> boot variable to PCR[1]
> 
> Reviewed-by: Jiewen Yao <jiewen....@intel.com>
> 
> > -----Original Message-----
> > From: Xu, Min M <min.m...@intel.com>
> > Sent: Wednesday, January 18, 2023 7:53 AM
> > To: devel@edk2.groups.io
> > Cc: Xu, Min M <min.m...@intel.com>; Yao, Jiewen
> <jiewen....@intel.com>;
> > Wang, Jian J <jian.j.w...@intel.com>
> > Subject: [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to
> > PCR[1]
> >
> > From: Min M Xu <min.m...@intel.com>
> >
> > According to TCG PC Client PFP spec 0021 Section 2.4.4.2 EFI boot variable
> > should be measured and extended to PCR[1], not PCR[5]. This patch is
> > proposed to fix this error.
> >
> > Cc: Jiewen Yao <jiewen....@intel.com>
> > Cc: Jian J Wang <jian.j.w...@intel.com>
> > Reviewed-by: Jiewen Yao <jiewen....@intel.com>
> > Signed-off-by: Min Xu <min.m...@intel.com>
> > ---
> >  SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
> > b/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
> > index d19923b0c682..59341a8c0250 100644
> > --- a/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
> > +++ b/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
> > @@ -1873,12 +1873,8 @@ ReadAndMeasureBootVariable (
> >    OUT     VOID      **VarData
> >    )
> >  {
> > -  //
> > -  // Boot variables are measured into (PCR[5]) RTMR[1],
> > -  // details in section 8.1 of TDVF design guide.
> > -  //
> >    return ReadAndMeasureVariable (
> > -           MapPcrToMrIndex (5),
> > +           MapPcrToMrIndex (1),
> >             EV_EFI_VARIABLE_BOOT,
> >             VarName,
> >             VendorGuid,
> > --
> > 2.29.2.windows.2
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98761): https://edk2.groups.io/g/devel/message/98761
Mute This Topic: https://groups.io/mt/96343925/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to