On Wed, 18 Jan 2023 at 09:28, Oliver Steffen <ostef...@redhat.com> wrote:
>
> Quoting Ard Biesheuvel (2023-01-18 08:34:32)
> > On Wed, 18 Jan 2023 at 07:37, Oliver Steffen <ostef...@redhat.com> wrote:
> > >
> > > On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel <a...@kernel.org> wrote:
> > >>
> > >> On Tue, 17 Jan 2023 at 13:48, Oliver Steffen <ostef...@redhat.com> wrote:
> > >> >
> > >> > Hi Ard, Hi everyone,
> > >> >
> > >> > Thanks for the work!
> > >> >
> > >> > But somehow this patch (as it was merged into master branch) does not
> > >> > work for me on the ThunderX box we have.
> > >> >
> > >> > Any idea what could be wrong?
> > >>
> > >> I'm not sure I understand the question. The patch targets ThunderX,
> > >> and you are using a ThunderX2.
> > >>
> > >> What were you expecting to happen, and what is happening instead?
> > >
> > >
> > > Firmware does not start at all when using KVM.
> > >
> > > Please excuse my limited knowledge of Arm processor variants.
> > > I assumed that ThunderX and ThunderX2 are very similar and hoped
> > > the fix would also work for this case.
> > >
> > > The issue was introduced by the same commit that Dann
> > > reported (07be1d34d95460a238fcd0f6693efb747c28b329):
> > > "ArmVirtPkg/ArmVirtQemu: enable initial ID map at early boot".
> > >
> >
> > Can you share the QEMU command line that you are using? I use a
> > ThunderX2 basically 24/7 to do all my Linux and EDK2 development, so
> > this change was developed on ThunderX2 and so I'm surprised you are
> > seeing this issue.
> >
> > Did you try the DEBUG build as well?
> Yes, debug is on.
>
> Here is what I have, trying with the master branch from just now
> (998ebe5ca0ae5c449e83ede533bee872f97d63af):
>
> # make -C BaseTools && \
> . ./edksetup.sh && \
> build -t GCC5 -a AARCH64 \
> -p ArmVirtPkg/ArmVirtQemu.dsc \
> -DCAVIUM_ERRATUM_27456 \
> -b DEBUG
>
> # /usr/libexec/qemu-kvm \
> -machine accel=kvm -m 1G -boot menu=on \
> -blockdev
> node-name=code,driver=file,filename="${FW_CODE_RESIZED}",read-only=on
> \
> -blockdev node-name=vars,driver=file,filename="${FW_VARS}" \
> -machine pflash0=code \
> -machine pflash1=vars \
> -cpu max \
> -net none \
> -serial stdio
>
My distro does not have qemu-kvm, and using the command line above
results in the following if i try it with qemu-system-aarch64
"""
qemu-system-aarch64: No machine specified, and there is no default
Use -machine help to list supported machines
"""
unless i change it to
qemu-system-aarch64 -machine virt,accel=kvm -m 1G -boot menu=on \
-blockdev
node-name=code,driver=file,filename=$HOME/bin/flash0.img,read-only=on
\
-blockdev node-name=vars,driver=file,filename=$HOME/bin/flash1.img \
-machine pflash0=code \
-machine pflash1=vars \
-cpu max \
-net none \
-nographic
and that works fine with my firmware build.
> # /usr/libexec/qemu-kvm --version
> QEMU emulator version 7.2.0 (qemu-kvm-7.2.0-3.el9)
>
> # uname -r
> 5.14.0-234.el9.aarch64
>
Yeah, that is quite old. One potential issue that comes to mind here
is the one address by the patch below
>
>
> Since you have the same CPU... Might this be a bug in KVM?
>
Indeed. Could you try applying this patch?
commit 406504c7b0405d74d74c15a667cd4c4620c3e7a9
Author: Marc Zyngier <m...@kernel.org>
Date: Tue Dec 20 14:03:52 2022 +0000
KVM: arm64: Fix S1PTW handling on RO memslots
Or check whether this is generally reproducible with newer kernels?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98776): https://edk2.groups.io/g/devel/message/98776
Mute This Topic: https://groups.io/mt/96075174/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
