New patch here since I had already pushed. https://edk2.groups.io/g/devel/message/98829
Thanks, Isaac -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran Sent: Friday, January 13, 2023 6:46 AM To: devel@edk2.groups.io; Oram, Isaac W <isaac.w.o...@intel.com> Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com>; Bi, Dandan <dandan...@intel.com> Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Features/Intel: Prepare for edk2-platforms CI On 1/9/23 17:05, Isaac Oram wrote: > --- /dev/null > +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md ... > +## Windows Example: > +With current working directory at O:\ > + > +git clone https://github.com/tianocore/edk2.git > + > +git clone https://github.com/tianocore/edk2-platforms.git > + > +set workspace=O:\ > + > +set EDK_TOOLS_PATH=O:\Edk2\BaseTools Would "set workspace=%cd%" work better? That would avoid hard-coding the assumption that the workspace is on the O: drive. Then, subsequent paths should be %workspace%\edk2;%workspace%\edk2-non-osi etc. > + > +set > +packages_path=O:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Inte > +l;O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\ > +edk2-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2- > +platforms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\N > +etwork;O:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-p > +latforms\Features\Intel\PowerManagement;O:\edk2-platforms\Features\In > +tel\SystemInformation;O:\edk2-platforms\Features\Intel\UserInterface > + > +cd \edk2 Either here or earlier you probably want to add a step of running "git submodule update --init" otherwise the Rebuild step below will fail. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98831): https://edk2.groups.io/g/devel/message/98831 Mute This Topic: https://groups.io/mt/96166945/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-