Hi Ard,
Thanks for your review.
Because I have saw the last patch has been accepted into
https://github.com/tianocore/edk2-non-osi.git
So, I use another patch to fix the typo.
Do you mean that I need to send my last patch again with corrected the
.inf files?
BR,
by Tommy
> -----Original Message-----
> From: Ard Biesheuvel <a...@kernel.org>
> Sent: Tuesday, January 31, 2023 7:38 PM
> To: devel@edk2.groups.io; Tommy Huang <tommy_hu...@aspeedtech.com>
> Cc: nathaniel.l.desim...@intel.com; isaac.w.o...@intel.com;
> quic_llind...@quicinc.com; michael.d.kin...@intel.com; Ryan Chen
> <ryan_c...@aspeedtech.com>; BMC-SW <bmc...@aspeedtech.com>
> Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg:
> Correct all INF_VERSION value
>
> On Mon, 30 Jan 2023 at 03:09, Tommy Huang
> <tommy_hu...@aspeedtech.com> wrote:
> >
> > 1. Correct all INF_VERSION value.
> >
> > Cc: Isaac Oram <isaac.w.o...@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
> > Cc: Leif Lindholm <quic_llind...@quicinc.com>
> > Cc: Michael D Kinney <michael.d.kin...@intel.com>
> > Cc: Ryan Chen <ryan_c...@aspeedtech.com>
> > Cc: BMC-SW <bmc...@aspeedtech.com>
> >
> > Signed-off-by: Tommy Huang <tommy_hu...@aspeedtech.com>
>
> This patch does not apply
>
> Please generate your patch against
> https://github.com/tianocore/edk2-non-osi.git
>
>
> > ---
> > Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++--
> > Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > index d6a674c..6bda488 100644
> > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > @@ -10,11 +10,11 @@
> > ##
> >
> >
> >
> > [Defines]
> >
> > - INF_VERSION = 0x00011302
> > + INF_VERSION = 1.29
> > BASE_NAME = ASpeedAst2500GopDxe
> >
> > FILE_GUID =
> 7F81D838-F91D-4C44-8552-8FB912122FDD
> >
> > MODULE_TYPE = UEFI_DRIVER
> >
> > - VERSION_STRING = 1.29
> > + VERSION_STRING = 1.13.02
> >
> >
> > [Binaries.AArch64]
> >
> > PE32|AArch64/ASpeedAst2500Gop.efi|*
> >
> > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > index a652ced..3375407 100644
> > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > @@ -9,11 +9,11 @@
> > ##
> >
> > [Defines]
> > - INF_VERSION = 0x00011302
> > + INF_VERSION = 1.29
> > BASE_NAME = ASpeedAst2600GopDxe
> > FILE_GUID =
> 36f08597-2a8d-4824-9416-59c810b0d9f3
> > MODULE_TYPE = UEFI_DRIVER
> > - VERSION_STRING = 1.29
> > + VERSION_STRING = 1.13.02
> >
> > [Binaries.AArch64]
> > PE32|AArch64/ASpeedAst2600Gop.efi|*
> > --
> > 2.25.1
> >
> >
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99348): https://edk2.groups.io/g/devel/message/99348
Mute This Topic: https://groups.io/mt/96619610/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
