Hi Swatisri,

Thank you for this patch.

This patch must be 1/2 to prevent git bisect from failing. Otherwise these changes look good to me.

With that addressed,

Reviewed-by: Sami Mujawar <sami.muja...@arm.com>

Regards,

Sami Mujawar

On 25/01/2023 06:40 pm, Name wrote:
From: Swatisri Kantamsetti <swatis...@nvidia.com>

The IO Remapping Table, Platform Design Document, Revision E.e,
Sept 2022 (https://developer.arm.com/documentation/den0049/ee)
added flags in SMMUv3 node for validity of ID mappings for MSIs
related to control interrupts.

Therefore, update the IORT header file to:
- increment IORT table revision to 6
- add support for DeviceId valid flag

Signed-off-by: Swatisri Kantamsetti <swatis...@nvidia.com>
---
  MdePkg/Include/IndustryStandard/IoRemappingTable.h | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/IoRemappingTable.h 
b/MdePkg/Include/IndustryStandard/IoRemappingTable.h
index f48a4a95cd..544aa67a05 100644
--- a/MdePkg/Include/IndustryStandard/IoRemappingTable.h
+++ b/MdePkg/Include/IndustryStandard/IoRemappingTable.h
@@ -9,6 +9,8 @@
    @par Reference(s):
    - IO Remapping Table, Platform Design Document, Revision E.d, Feb 2022
      (https://developer.arm.com/documentation/den0049/)
+  - IO Remapping Table, Platform Design Document, Revision E.e, Sept 2022
+      (https://developer.arm.com/documentation/den0049/)
@par Glossary:
    - Ref  : Reference
@@ -24,6 +26,7 @@
  #define EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00  0x0
  #define EFI_ACPI_IO_REMAPPING_TABLE_REVISION_04  0x4   // Deprecated
  #define EFI_ACPI_IO_REMAPPING_TABLE_REVISION_05  0x5
+#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION_06  0x6
#define EFI_ACPI_IORT_TYPE_ITS_GROUP 0x0
  #define EFI_ACPI_IORT_TYPE_NAMED_COMP    0x1
@@ -59,6 +62,7 @@
  #define EFI_ACPI_IORT_SMMUv3_FLAG_COHAC_OVERRIDE    BIT0
  #define EFI_ACPI_IORT_SMMUv3_FLAG_HTTU_OVERRIDE     BIT1
  #define EFI_ACPI_IORT_SMMUv3_FLAG_PROXIMITY_DOMAIN  BIT3
+#define EFI_ACPI_IORT_SMMUv3_FLAG_DEVICEID_VALID    BIT4
#define EFI_ACPI_IORT_SMMUv3_MODEL_GENERIC 0x0
  #define EFI_ACPI_IORT_SMMUv3_MODEL_HISILICON_HI161X  0x1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99656): https://edk2.groups.io/g/devel/message/99656
Mute This Topic: https://groups.io/mt/96534671/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to