Hi Michael, Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>
Please update commit message from Ab to Rb and I will merge. Thanks, Mike > -----Original Message----- > From: Michael Kubacki <mikub...@linux.microsoft.com> > Sent: Tuesday, February 7, 2023 7:50 PM > To: devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn> > Cc: Chris Fernald <chris.fern...@outlook.com>; Oliver Steffen > <ostef...@redhat.com>; Sean Brogan <spbro...@outlook.com>; Kinney, > Michael D <michael.d.kin...@intel.com>; Leif Lindholm > <quic_llind...@quicinc.com>; Andrew Fish <af...@apple.com> > Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add > devcontainer file > > Hi Liming, > > I put the patch with received review tags in the following PR: > > https://github.com/tianocore/edk2/pull/4015 > > Thanks, > Michael > > On 2/5/2023 1:34 PM, Michael Kubacki wrote: > > With the soft freeze starting soon, I wanted to bring attention to this > > patch again. It has not received feedback in 2+ weeks on the list. > > > > It is simple and intended to help users more easily use Tianocore > > containers. > > > > Can you please review and include this in the stable tag? > > > > Thanks, > > Michael > > > > On 1/26/2023 9:44 AM, Michael Kubacki wrote: > >> I've seen interest on the patch but no R-b yet. I believe those in the > >> TO line might be the best to provide that since this is a new directory. > >> > >> If anyone is interested in being a maintainer/reviewer, let me know > >> and I'll update the file. > >> > >> Thanks, > >> Michael > >> > >> On 1/20/2023 3:51 PM, Michael Kubacki wrote: > >>> From: Michael Kubacki <michael.kuba...@microsoft.com> > >>> > >>> Tianocore maintains container images in the tianocore/containers repo > >>> and stores container images within the GitHub container registry. > >>> > >>> https://github.com/tianocore/containers > >>> > >>> This change adds a devcontainer.json file to the edk2 repo. This > >>> file's metadata and settings to configurate a development container > >>> for a given well-defined tool and runtime stack. > >>> > >>> More information about the devcontainer.json file is available here: > >>> https://containers.dev/implementors/json_reference/ > >>> > >>> This file is recognized by popular tools such as GitHub Codespaces > >>> and VS Code. In VS Code in particular, it makes it much easier for > >>> a user to be aware a dev container exists (via UI notifications) > >>> and to load the container. > >>> > >>> A minimal number of VS Code extensions are specified that are useful > >>> for edk2 development or to assist in complying with CI checks in > >>> place in edk2. > >>> > >>> Cc: Andrew Fish <af...@apple.com> > >>> Cc: Chris Fernald <chris.fern...@outlook.com> > >>> Cc: Leif Lindholm <quic_llind...@quicinc.com> > >>> Cc: Michael D Kinney <michael.d.kin...@intel.com> > >>> Cc: Oliver Steffen <ostef...@redhat.com> > >>> Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > >>> --- > >>> .devcontainer/devcontainer.json | 16 ++++++++++++++++ > >>> Maintainers.txt | 5 +++++ > >>> 2 files changed, 21 insertions(+) > >>> > >>> diff --git a/.devcontainer/devcontainer.json > >>> b/.devcontainer/devcontainer.json > >>> new file mode 100644 > >>> index 000000000000..592bb8cf6626 > >>> --- /dev/null > >>> +++ b/.devcontainer/devcontainer.json > >>> @@ -0,0 +1,16 @@ > >>> +{ > >>> + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > >>> + "postCreateCommand": "git config --global --add safe.directory * > >>> && pip install --upgrade -r pip-requirements.txt", > >>> + "customizations": { > >>> + "vscode": { > >>> + "extensions": [ > >>> + "DavidAnson.vscode-markdownlint", > >>> + "ms-azuretools.vscode-docker", > >>> + "ms-vscode-remote.remote-containers", > >>> + "ms-vscode.cpptools", > >>> + "walonli.edk2-vscode", > >>> + "zachflower.uncrustify" > >>> + ] > >>> + } > >>> + } > >>> +} > >>> diff --git a/Maintainers.txt b/Maintainers.txt > >>> index 68f603b48398..4aa7973d5156 100644 > >>> --- a/Maintainers.txt > >>> +++ b/Maintainers.txt > >>> @@ -117,6 +117,11 @@ M: Michael Kubacki > >>> <mikub...@linux.microsoft.com> [makubacki] > >>> R: Michael D Kinney <michael.d.kin...@intel.com> [mdkinney] > >>> R: Liming Gao <gaolim...@byosoft.com.cn> [lgao4] > >>> +.devcontainer/ > >>> +F: .devcontainer/ > >>> +M: Michael Kubacki <mikub...@linux.microsoft.com> [makubacki] > >>> +R: Chris Fernald <chris.fern...@outlook.com> [cfernald] > >>> + > >>> .github/ > >>> F: .github/ > >>> M: Sean Brogan <sean.bro...@microsoft.com> [spbrogan] > >> > >> > >> > >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99950): https://edk2.groups.io/g/devel/message/99950 Mute This Topic: https://groups.io/mt/96409896/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
