Gerd, All the 4 are needed to make sure SMM still works. Only having one will cause system hang. I think Jiaxin's commit message is to describe what has been done to enable the single feature: Early SMM rebase.
Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd > Hoffmann > Sent: Friday, February 10, 2023 7:27 PM > To: Wu, Jiaxin <jiaxin...@intel.com> > Cc: devel@edk2.groups.io; Dong, Eric <eric.d...@intel.com>; Ni, Ray > <ray...@intel.com>; Zeng, Star <star.z...@intel.com>; Laszlo Ersek > <ler...@redhat.com>; Kumar, Rahul R <rahul.r.ku...@intel.com> > Subject: Re: [edk2-devel] [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: > Consume SMM Base Hob for SmBase info > > > Mainly changes as below: > > * Assume the biggest possibility of tile size is 8k. > > * Combine 2 SMIs (gcSmmInitTemplate & gcSmiHandlerTemplate) into one > > (gcSmiHandlerTemplate), the new SMI handler needs to run to 2 paths: > > one to SmmCpuFeaturesInitializeProcessor(), the other to SMM Core > > Entry Point. > > * Issue SMI IPI (All Excluding Self SMM IPI + BSP SMM IPI) for first > > SMI init before normal SMI sources happen. > > * Call SmmCpuFeaturesInitializeProcessor() in parallel. > > Four changes in a single patch. Please split them up. > > thanks, > Gerd > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100005): https://edk2.groups.io/g/devel/message/100005 Mute This Topic: https://groups.io/mt/96871374/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
